mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Lee Jones <lee@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: core: Un-constify mfd_cell.of_reg
Date: Tue, 22 Aug 2023 21:36:01 +0200	[thread overview]
Message-ID: <ZOUOIT40/qH7VOTS@qmqm.qmqm.pl> (raw)
In-Reply-To: <20230821081340.GD1380343@google.com>

On Mon, Aug 21, 2023 at 09:13:40AM +0100, Lee Jones wrote:
> On Sat, 19 Aug 2023, Michał Mirosław wrote:
> 
> > On Fri, Aug 18, 2023 at 04:58:15PM +0100, Lee Jones wrote:
> > > On Wed, 16 Aug 2023, Michał Mirosław wrote:
> > > 
> > > > of_reg is the only constant member of struct mfd_cell. It seems to be
> > > 
> > > Sorry, what?
> > > 
> > > struct mfd_cell {
> > >         const char              *name;
> > > [...]
> > >         const struct mfd_cell_acpi_match        *acpi_match;
> > > [...]
> > >         const struct software_node *swnode;
> > > [...]
> > >         const char              *of_compatible;
> > > [...]
> > >         const u64 of_reg;
> > > [...]
> > >         const struct resource   *resources;
> > > [...]
> > >         const char * const      *parent_supplies;
> > > [...]
> > > };
> > [...]
> > 
> > All those are pointers to const, not const fields themselves. Only
> > `of_reg` is const regardless of the whole structure.
> 
> Please make that clear in the commit message.

Could you please help with the wording? I'm surprised being asked to explain
a basic C language feature in a commit message to have a patch accepted.
Could it be due to me using 'constant' instead of 'const' that made it
confusing?

Best Regards
Michał Mirosław

  reply	other threads:[~2023-08-22 19:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-16 12:27 Michał Mirosław
2023-08-18 15:58 ` Lee Jones
2023-08-19  0:11   ` Michał Mirosław
2023-08-21  8:13     ` Lee Jones
2023-08-22 19:36       ` Michał Mirosław [this message]
2023-08-24 12:19         ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZOUOIT40/qH7VOTS@qmqm.qmqm.pl \
    --to=mirq-linux@rere.qmqm.pl \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®