* [PATCH -next] greybus: svc: Remove unused declarations
@ 2023-08-18 12:43 Yue Haibing
2023-08-22 14:32 ` Greg KH
2023-08-23 7:44 ` Johan Hovold
0 siblings, 2 replies; 4+ messages in thread
From: Yue Haibing @ 2023-08-18 12:43 UTC (permalink / raw)
To: johan, elder, gregkh, yuehaibing; +Cc: greybus-dev, linux-kernel
Commit 84427943d2da ("greybus: svc: drop legacy-protocol dependency")
removed these implementations but not the declarations.
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
include/linux/greybus/svc.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/linux/greybus/svc.h b/include/linux/greybus/svc.h
index 5afaf5f06856..da547fb9071b 100644
--- a/include/linux/greybus/svc.h
+++ b/include/linux/greybus/svc.h
@@ -100,7 +100,4 @@ bool gb_svc_watchdog_enabled(struct gb_svc *svc);
int gb_svc_watchdog_enable(struct gb_svc *svc);
int gb_svc_watchdog_disable(struct gb_svc *svc);
-int gb_svc_protocol_init(void);
-void gb_svc_protocol_exit(void);
-
#endif /* __SVC_H */
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] greybus: svc: Remove unused declarations
2023-08-18 12:43 [PATCH -next] greybus: svc: Remove unused declarations Yue Haibing
@ 2023-08-22 14:32 ` Greg KH
2023-08-22 14:49 ` Yue Haibing
2023-08-23 7:44 ` Johan Hovold
1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2023-08-22 14:32 UTC (permalink / raw)
To: Yue Haibing; +Cc: johan, elder, greybus-dev, linux-kernel
On Fri, Aug 18, 2023 at 08:43:38PM +0800, Yue Haibing wrote:
> Commit 84427943d2da ("greybus: svc: drop legacy-protocol dependency")
> removed these implementations but not the declarations.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> include/linux/greybus/svc.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/greybus/svc.h b/include/linux/greybus/svc.h
> index 5afaf5f06856..da547fb9071b 100644
> --- a/include/linux/greybus/svc.h
> +++ b/include/linux/greybus/svc.h
> @@ -100,7 +100,4 @@ bool gb_svc_watchdog_enabled(struct gb_svc *svc);
> int gb_svc_watchdog_enable(struct gb_svc *svc);
> int gb_svc_watchdog_disable(struct gb_svc *svc);
>
> -int gb_svc_protocol_init(void);
> -void gb_svc_protocol_exit(void);
> -
> #endif /* __SVC_H */
> --
> 2.34.1
>
Nice, how did you find these?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] greybus: svc: Remove unused declarations
2023-08-22 14:32 ` Greg KH
@ 2023-08-22 14:49 ` Yue Haibing
0 siblings, 0 replies; 4+ messages in thread
From: Yue Haibing @ 2023-08-22 14:49 UTC (permalink / raw)
To: Greg KH; +Cc: johan, elder, greybus-dev, linux-kernel
On 2023/8/22 22:32, Greg KH wrote:
> On Fri, Aug 18, 2023 at 08:43:38PM +0800, Yue Haibing wrote:
>> Commit 84427943d2da ("greybus: svc: drop legacy-protocol dependency")
>> removed these implementations but not the declarations.
>>
>> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>> ---
>> include/linux/greybus/svc.h | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/include/linux/greybus/svc.h b/include/linux/greybus/svc.h
>> index 5afaf5f06856..da547fb9071b 100644
>> --- a/include/linux/greybus/svc.h
>> +++ b/include/linux/greybus/svc.h
>> @@ -100,7 +100,4 @@ bool gb_svc_watchdog_enabled(struct gb_svc *svc);
>> int gb_svc_watchdog_enable(struct gb_svc *svc);
>> int gb_svc_watchdog_disable(struct gb_svc *svc);
>>
>> -int gb_svc_protocol_init(void);
>> -void gb_svc_protocol_exit(void);
>> -
>> #endif /* __SVC_H */
>> --
>> 2.34.1
>>
>
> Nice, how did you find these?
Just use grep to check like below, then filter out known false item
grep -rP --include=*.h '^(?:\w+\s+){1,3}\*{0,3}\s{0,3}\w+[\t]*\(' * |grep -P -oh '\w+\s*\('|sort| uniq -c| sort -n| grep -P '^\s+1\b'|sed -r -e 's/^\s+1\s+//' -e 's/\(//'|while read line ;
do
CNT=`git grep -w $line |wc -l` ;
if [ $CNT -eq 1 ];then
git grep -wn $line
fi
done
> .
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] greybus: svc: Remove unused declarations
2023-08-18 12:43 [PATCH -next] greybus: svc: Remove unused declarations Yue Haibing
2023-08-22 14:32 ` Greg KH
@ 2023-08-23 7:44 ` Johan Hovold
1 sibling, 0 replies; 4+ messages in thread
From: Johan Hovold @ 2023-08-23 7:44 UTC (permalink / raw)
To: Yue Haibing; +Cc: elder, gregkh, greybus-dev, linux-kernel
On Fri, Aug 18, 2023 at 08:43:38PM +0800, Yue Haibing wrote:
> Commit 84427943d2da ("greybus: svc: drop legacy-protocol dependency")
> removed these implementations but not the declarations.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> include/linux/greybus/svc.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/greybus/svc.h b/include/linux/greybus/svc.h
> index 5afaf5f06856..da547fb9071b 100644
> --- a/include/linux/greybus/svc.h
> +++ b/include/linux/greybus/svc.h
> @@ -100,7 +100,4 @@ bool gb_svc_watchdog_enabled(struct gb_svc *svc);
> int gb_svc_watchdog_enable(struct gb_svc *svc);
> int gb_svc_watchdog_disable(struct gb_svc *svc);
>
> -int gb_svc_protocol_init(void);
> -void gb_svc_protocol_exit(void);
> -
> #endif /* __SVC_H */
Yup, these are long gone:
Reviewed-by: Johan Hovold <johan@kernel.org>
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-23 7:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-18 12:43 [PATCH -next] greybus: svc: Remove unused declarations Yue Haibing
2023-08-22 14:32 ` Greg KH
2023-08-22 14:49 ` Yue Haibing
2023-08-23 7:44 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®