From: Francesco Dolcini <francesco@dolcini.it>
To: David Lin <yu-hao.lin@nxp.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sharvari Harisangam <sharvari.harisangam@nxp.com>,
Pete Hsieh <tsung-hsien.hsieh@nxp.com>,
"kvalo@kernel.org" <kvalo@kernel.org>,
"amitkarwar@gmail.com" <amitkarwar@gmail.com>,
"ganapathi017@gmail.com" <ganapathi017@gmail.com>,
"huxinming820@gmail.com" <huxinming820@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>
Subject: Re: [PATCH v4 1/1] wifi: mwifiex: added code to support host mlme.
Date: Fri, 25 Aug 2023 12:04:28 +0200 [thread overview]
Message-ID: <ZOh8deIyeJMZAs7u@francesco-nb.int.toradex.com> (raw)
In-Reply-To: <PA4PR04MB96386B2937FE0F7BD0BFAEB3D114A@PA4PR04MB9638.eurprd04.prod.outlook.com>
Hello David,
thanks for your patch.
On Tue, Aug 15, 2023 at 07:09:25AM +0000, David Lin wrote:
> 1. For station mode first.
> 2. This feature is a must for WPA3.
> 3. Firmware key api version 2 is needed for this feature.
> 4. The code is only enabled and tested with IW416.
> 5. This feature is disabled for other chips.
>
> Signed-off-by: David Lin <yu-hao.lin@nxp.com>
I think you are missing a few of the comments you received so far.
- verify the recipient list, the list here was likely generated with an
old kernel tree using an outdated MAINTAINERS file
- you need to provide a changelog in your patch, otherwise is not
possible for other to review
- some concern were raised on the fact that this is tested only with
IW416, we should have some confidence this is not creating regressions.
Francesco
next prev parent reply other threads:[~2023-08-25 10:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 7:09 David Lin
2023-08-25 10:04 ` Francesco Dolcini [this message]
2023-08-28 9:30 ` [EXT] " David Lin
2023-08-28 10:10 ` Francesco Dolcini
2023-08-28 23:56 ` David Lin
2023-09-26 14:39 ` Francesco Dolcini
2023-10-17 2:46 ` [EXT] " David Lin
2023-10-24 7:46 ` David Lin
2023-08-15 10:12 David Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOh8deIyeJMZAs7u@francesco-nb.int.toradex.com \
--to=francesco@dolcini.it \
--cc=amitkarwar@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ganapathi017@gmail.com \
--cc=huxinming820@gmail.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sharvari.harisangam@nxp.com \
--cc=tsung-hsien.hsieh@nxp.com \
--cc=yu-hao.lin@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®