From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linhua Xu <Linhua.xu@unisoc.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
lh xu <xulh0829@gmail.com>,
Xiongpeng Wu <xiongpeng.wu@unisoc.com>
Subject: Re: [PATCH 5/6] pinctrl: sprd: Increase the range of register values
Date: Fri, 25 Aug 2023 13:19:38 +0300 [thread overview]
Message-ID: <ZOiAOqpJsd7ljyal@smile.fi.intel.com> (raw)
In-Reply-To: <20230825031826.31599-6-Linhua.xu@unisoc.com>
On Fri, Aug 25, 2023 at 11:18:25AM +0800, Linhua Xu wrote:
> From: Linhua Xu <Linhua.Xu@unisoc.com>
>
> As the UNISOC pin controller version iterates, more registers are required
> to meet new functional requirements. Thus modify them.
...
+ bits.h and...
> +#define NUM_OFFSET (22)
> +#define TYPE_OFFSET (18)
> +#define BIT_OFFSET (10)
> +#define WIDTH_OFFSET (6)
Why do you need parentheses? Also what do these represent
(since they are decimal numbers)?
...
> #define SPRD_PIN_INFO(num, type, offset, width, reg) \
> (((num) & 0xFFF) << NUM_OFFSET | \
> ((type) & 0xF) << TYPE_OFFSET | \
> ((offset) & 0xFF) << BIT_OFFSET | \
> ((width) & 0xF) << WIDTH_OFFSET | \
> - ((reg) & 0xF))
> + ((reg) & 0x1F))
...use GENMASK() everywhere above.
...
> .type = (((a) >> TYPE_OFFSET) & 0xf), \
> .bit_offset = (((a) >> BIT_OFFSET) & 0xff), \
> .bit_width = ((a) >> WIDTH_OFFSET & 0xf), \
> - .reg = ((a) & 0xf) \
> + .reg = ((a) & 0x1f) \
Ditto.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-25 10:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 3:18 [PATCH 0/6] pinctrl: sprd: Modification of UNIOC Platform pinctrl Driver Linhua Xu
2023-08-25 3:18 ` [PATCH 1/6] pinctrl: sprd: Modify the probe function parameters Linhua Xu
2023-08-25 5:25 ` kernel test robot
2023-08-25 10:08 ` Andy Shevchenko
2023-08-25 3:18 ` [PATCH 2/6] pinctrl: sprd: Fix the incorrect mask and shift definition Linhua Xu
2023-08-25 10:10 ` Andy Shevchenko
2023-08-25 3:18 ` [PATCH 3/6] pinctrl: sprd: Modify pull-up parameters Linhua Xu
2023-08-25 10:13 ` Andy Shevchenko
2023-08-25 3:18 ` [PATCH 4/6] pinctrl: sprd: Add pinctrl support for UMS512 Linhua Xu
2023-08-25 10:17 ` Andy Shevchenko
2023-08-25 3:18 ` [PATCH 5/6] pinctrl: sprd: Increase the range of register values Linhua Xu
2023-08-25 10:19 ` Andy Shevchenko [this message]
2023-08-25 3:18 ` [PATCH 6/6] pinctrl: sprd: Add pinctrl support for UMS9621 Linhua Xu
2023-08-25 10:20 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOiAOqpJsd7ljyal@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Linhua.xu@unisoc.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=xiongpeng.wu@unisoc.com \
--cc=xulh0829@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®