[PATCH 1/6] staging: octeon: clean up the octeon ethernet driver

[PATCH 1/6] staging: octeon: clean up the octeon ethernet driver

[Oliver Crumrine]

Make the octeon ethernet driver better adhere to the
kernel coding standard

Signed-off-by: Oliver Crumrine <ozlinux@hotmail.com>
---
 drivers/staging/octeon/octeon-stubs.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
index 3e7b92cd2e35..9f269626b862 100644
--- a/drivers/staging/octeon/octeon-stubs.h
+++ b/drivers/staging/octeon/octeon-stubs.h
@@ -213,12 +213,12 @@ enum cvmx_fau_op_size {
 	CVMX_FAU_OP_SIZE_64 = 3
 };
 
-typedef enum {
+enum cvmx_spi_mode {
 	CVMX_SPI_MODE_UNKNOWN = 0,
 	CVMX_SPI_MODE_TX_HALFPLEX = 1,
 	CVMX_SPI_MODE_RX_HALFPLEX = 2,
 	CVMX_SPI_MODE_DUPLEX = 3
-} cvmx_spi_mode_t;
+};
 
 typedef enum {
 	CVMX_HELPER_INTERFACE_MODE_DISABLED,
@@ -1362,7 +1362,7 @@ static inline struct cvmx_wqe *cvmx_pow_work_request_sync(cvmx_pow_wait_t wait)
 }
 
 static inline int cvmx_spi_restart_interface(int interface,
-					cvmx_spi_mode_t mode, int timeout)
+					enum cvmx_spi_mode mode, int timeout)
 {
 	return 0;
 }
-- 
2.39.3

Re: [PATCH 1/6] staging: octeon: clean up the octeon ethernet driver

[Nam Cao]

On Sun, Aug 27, 2023 at 05:12:04PM -0400, Oliver Crumrine wrote:
> Make the octeon ethernet driver better adhere to the
> kernel coding standard
> 
> Signed-off-by: Oliver Crumrine <ozlinux@hotmail.com>

See this conversation about a similar mistake that you also made with your
patch series:
https://lore.kernel.org/linux-staging/ZOpq4t22iRXewekD@alolivei-thinkpadt480s.gru.csb/T/#t

Best regards,
Nam

Re: [PATCH 1/6] staging: octeon: clean up the octeon ethernet driver

[ozlinux]

On Mon, Aug 28, 2023 at 12:27:10AM +0200, Nam Cao wrote:
> On Sun, Aug 27, 2023 at 05:12:04PM -0400, Oliver Crumrine wrote:
> > Make the octeon ethernet driver better adhere to the
> > kernel coding standard
> > 
> > Signed-off-by: Oliver Crumrine <ozlinux@hotmail.com>
> 
> See this conversation about a similar mistake that you also made with your
> patch series:
> https://lore.kernel.org/linux-staging/ZOpq4t22iRXewekD@alolivei-thinkpadt480s.gru.csb/T/#t
> 
> Best regards,
> Nam

That is totally my bad. Should I leave it as is? Should I resend the
whole patch set? Should I resend just the last five, but attach them to
the first one? This is my first kernel patch, so I'll take any advice I
can get.

Thanks,
Oliver

Re: [PATCH 1/6] staging: octeon: clean up the octeon ethernet driver

[Nam Cao]

On Mon, Aug 28, 2023 at 12:32 AM <ozlinux@hotmail.com> wrote:
>
> On Mon, Aug 28, 2023 at 12:27:10AM +0200, Nam Cao wrote:
> > On Sun, Aug 27, 2023 at 05:12:04PM -0400, Oliver Crumrine wrote:
> > > Make the octeon ethernet driver better adhere to the
> > > kernel coding standard
> > >
> > > Signed-off-by: Oliver Crumrine <ozlinux@hotmail.com>
> >
> > See this conversation about a similar mistake that you also made with your
> > patch series:
> > https://lore.kernel.org/linux-staging/ZOpq4t22iRXewekD@alolivei-thinkpadt480s.gru.csb/T/#t
> >
> > Best regards,
> > Nam
>
> That is totally my bad. Should I leave it as is? Should I resend the
> whole patch set? Should I resend just the last five, but attach them to
> the first one? This is my first kernel patch, so I'll take any advice I
> can get.

You should resend everything. Don't forget to add the "v2" tag ;-)

Best regards,
Nam