* [PATCH] block: correct stale comment in rq_qos_wait
@ 2023-09-14 9:15 Kemeng Shi
2023-09-18 18:38 ` Tejun Heo
2023-09-18 20:15 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Kemeng Shi @ 2023-09-14 9:15 UTC (permalink / raw)
To: axboe, tj, linux-block, linux-kernel
The rq_qos_wait calls common wake-up function rq_qos_wake_function to get
token. Just replace stale wbt_wake_function with rq_qos_wake_function in
comment.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
block/blk-rq-qos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-rq-qos.c b/block/blk-rq-qos.c
index 167be74df4ee..dd7310c94713 100644
--- a/block/blk-rq-qos.c
+++ b/block/blk-rq-qos.c
@@ -270,7 +270,7 @@ void rq_qos_wait(struct rq_wait *rqw, void *private_data,
finish_wait(&rqw->wait, &data.wq);
/*
- * We raced with wbt_wake_function() getting a token,
+ * We raced with rq_qos_wake_function() getting a token,
* which means we now have two. Put our local token
* and wake anyone else potentially waiting for one.
*/
--
2.30.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] block: correct stale comment in rq_qos_wait
2023-09-14 9:15 [PATCH] block: correct stale comment in rq_qos_wait Kemeng Shi
@ 2023-09-18 18:38 ` Tejun Heo
2023-09-18 20:15 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2023-09-18 18:38 UTC (permalink / raw)
To: Kemeng Shi; +Cc: axboe, linux-block, linux-kernel
On Thu, Sep 14, 2023 at 05:15:08PM +0800, Kemeng Shi wrote:
> The rq_qos_wait calls common wake-up function rq_qos_wake_function to get
> token. Just replace stale wbt_wake_function with rq_qos_wake_function in
> comment.
>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] block: correct stale comment in rq_qos_wait
2023-09-14 9:15 [PATCH] block: correct stale comment in rq_qos_wait Kemeng Shi
2023-09-18 18:38 ` Tejun Heo
@ 2023-09-18 20:15 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2023-09-18 20:15 UTC (permalink / raw)
To: tj, linux-block, linux-kernel, Kemeng Shi
On Thu, 14 Sep 2023 17:15:08 +0800, Kemeng Shi wrote:
> The rq_qos_wait calls common wake-up function rq_qos_wake_function to get
> token. Just replace stale wbt_wake_function with rq_qos_wake_function in
> comment.
>
>
Applied, thanks!
[1/1] block: correct stale comment in rq_qos_wait
commit: e599ed7866cd804ca15de7a92f7f629944cc278d
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-18 20:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-14 9:15 [PATCH] block: correct stale comment in rq_qos_wait Kemeng Shi
2023-09-18 18:38 ` Tejun Heo
2023-09-18 20:15 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®