[PATCH] workqueue: Fix missed pwq_release_worker creation in wq_cpu_intensive_thresh_init()

[PATCH] workqueue: Fix missed pwq_release_worker creation in wq_cpu_intensive_thresh_init()

[Zqiang]

Currently, if the wq_cpu_intensive_thresh_us is set to specific
value, will cause the wq_cpu_intensive_thresh_init() early exit
and missed creation of pwq_release_worker. this commit therefore
create the pwq_release_worker in advance before checking the
wq_cpu_intensive_thresh_us.

Signed-off-by: Zqiang <qiang.zhang1211@gmail.com>
---
 kernel/workqueue.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index c85825e17df8..fd3988583c8b 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -6605,13 +6605,13 @@ static void __init wq_cpu_intensive_thresh_init(void)
 	unsigned long thresh;
 	unsigned long bogo;
 
+	pwq_release_worker = kthread_create_worker(0, "pool_workqueue_release");
+	BUG_ON(IS_ERR(pwq_release_worker));
+
 	/* if the user set it to a specific value, keep it */
 	if (wq_cpu_intensive_thresh_us != ULONG_MAX)
 		return;
 
-	pwq_release_worker = kthread_create_worker(0, "pool_workqueue_release");
-	BUG_ON(IS_ERR(pwq_release_worker));
-
 	/*
 	 * The default of 10ms is derived from the fact that most modern (as of
 	 * 2023) processors can do a lot in 10ms and that it's just below what
-- 
2.17.1

Re: [PATCH] workqueue: Fix missed pwq_release_worker creation in wq_cpu_intensive_thresh_init()

[Tejun Heo]

On Mon, Sep 11, 2023 at 04:27:22PM +0800, Zqiang wrote:
> Currently, if the wq_cpu_intensive_thresh_us is set to specific
> value, will cause the wq_cpu_intensive_thresh_init() early exit
> and missed creation of pwq_release_worker. this commit therefore
> create the pwq_release_worker in advance before checking the
> wq_cpu_intensive_thresh_us.
> 
> Signed-off-by: Zqiang <qiang.zhang1211@gmail.com>

Applied to wq/for-6.6-fixes.

Thanks.

-- 
tejun