mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Zhangjin Wu <falcon@tinylab.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/nolibc: add tests for multi-object linkage
Date: Thu, 12 Oct 2023 09:06:33 +0200	[thread overview]
Message-ID: <ZSea+etQwlxbi+Ok@1wt.eu> (raw)
In-Reply-To: <20231012-nolibc-linkage-test-v1-1-315e682768b4@weissschuh.net>

Hi Thomas,

On Thu, Oct 12, 2023 at 01:13:37AM +0200, Thomas Weißschuh wrote:
> While uncommon, nolibc executables can be linked together from multiple
> compilation units.
> Add some tests to make sure everything works in that case.
(...)

Glad you did these two. Your approach is good and it remains easy to
use and should catch next breakage in this area.

> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> Note:
> 
> This depends on path "tools/nolibc: mark start_c as weak".
> https://lore.kernel.org/lkml/20231012-nolibc-start_c-multiple-v1-1-fbfc73e0283f@weissschuh.net/

For these two patches: Acked-by: Willy Tarreau <w@1wt.eu>

Thanks
Willy

  reply	other threads:[~2023-10-12  7:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11 23:13 Thomas Weißschuh
2023-10-12  7:06 ` Willy Tarreau [this message]
2023-10-12  7:23   ` Thomas Weißschuh
2023-10-12 10:41     ` Paul E. McKenney
2023-10-12 10:51       ` Thomas Weißschuh
2023-10-12 18:25         ` Paul E. McKenney
2023-10-12 18:39           ` Thomas Weißschuh
2023-10-12 19:06             ` Paul E. McKenney
2023-10-12 19:34               ` Thomas Weißschuh
2023-10-12 20:18                 ` Paul E. McKenney
2023-10-16 16:24                   ` Paul E. McKenney
2023-10-16 22:03                     ` Thomas Weißschuh
2023-10-16 22:56                       ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZSea+etQwlxbi+Ok@1wt.eu \
    --to=w@1wt.eu \
    --cc=falcon@tinylab.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@weissschuh.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®