[PATCH] gnss: tell what GNSS means

[PATCH] gnss: tell what GNSS means

[Randy Dunlap]

Tell users what GNSS means in the Kconfig prompt.

Fixes: 2b6a44035143 ("gnss: add GNSS receiver subsystem")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/gnss/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -- a/drivers/gnss/Kconfig b/drivers/gnss/Kconfig
--- a/drivers/gnss/Kconfig
+++ b/drivers/gnss/Kconfig
@@ -4,7 +4,7 @@
 #
 
 menuconfig GNSS
-	tristate "GNSS receiver support"
+	tristate "GNSS (Global Navigation Satellite System) receiver support"
 	help
 	  Say Y here if you have a GNSS receiver (e.g. a GPS receiver).
 

Re: [PATCH] gnss: tell what GNSS means

[Johan Hovold]

On Sun, Sep 24, 2023 at 10:43:46PM -0700, Randy Dunlap wrote:
> Tell users what GNSS means in the Kconfig prompt.
 
>  menuconfig GNSS
> -	tristate "GNSS receiver support"
> +	tristate "GNSS (Global Navigation Satellite System) receiver support"

No, I don't like the way this clutters menuconfig. The above would make
this one of the longest entries and for very little gain.

We don't spell out NVMe or SPI either and I think the help text below
is clear enough as anyone not yet familiar with the concept of "GNSS
receivers" is sure to at least have heard of "GPS receivers" (which we
also don't spell out).

>  	help
>  	  Say Y here if you have a GNSS receiver (e.g. a GPS receiver).

Johan

Re: [PATCH] gnss: tell what GNSS means

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 626 bytes --]

On Mon 2023-10-16 16:38:28, Johan Hovold wrote:
> On Sun, Sep 24, 2023 at 10:43:46PM -0700, Randy Dunlap wrote:
> > Tell users what GNSS means in the Kconfig prompt.
>  
> >  menuconfig GNSS
> > -	tristate "GNSS receiver support"
> > +	tristate "GNSS (Global Navigation Satellite System) receiver support"
> 
> No, I don't like the way this clutters menuconfig. The above would make
> this one of the longest entries and for very little gain.

Yeah, because everyone knows what GNSS means.

Except that most people know GNSS as GPS. You misnamed the subsystem,
so it now needs explanation :-(.
								Pavel


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [PATCH] gnss: tell what GNSS means

[Randy Dunlap]

On 10/29/23 00:15, Pavel Machek wrote:
> On Mon 2023-10-16 16:38:28, Johan Hovold wrote:
>> On Sun, Sep 24, 2023 at 10:43:46PM -0700, Randy Dunlap wrote:
>>> Tell users what GNSS means in the Kconfig prompt.
>>  
>>>  menuconfig GNSS
>>> -	tristate "GNSS receiver support"
>>> +	tristate "GNSS (Global Navigation Satellite System) receiver support"
>>
>> No, I don't like the way this clutters menuconfig. The above would make
>> this one of the longest entries and for very little gain.
> 
> Yeah, because everyone knows what GNSS means.
> 
> Except that most people know GNSS as GPS. You misnamed the subsystem,
> so it now needs explanation :-(.
> 								Pavel

Thanks.  Obviously I agree.

-- 
~Randy

Re: [PATCH] gnss: tell what GNSS means

[Johan Hovold]

[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]

On Sun, Oct 29, 2023 at 08:15:41AM +0100, Pavel Machek wrote:
> On Mon 2023-10-16 16:38:28, Johan Hovold wrote:
> > On Sun, Sep 24, 2023 at 10:43:46PM -0700, Randy Dunlap wrote:
> > > Tell users what GNSS means in the Kconfig prompt.
> >  
> > >  menuconfig GNSS
> > > -	tristate "GNSS receiver support"
> > > +	tristate "GNSS (Global Navigation Satellite System) receiver support"
> > 
> > No, I don't like the way this clutters menuconfig. The above would make
> > this one of the longest entries and for very little gain.
> 
> Yeah, because everyone knows what GNSS means.

It's an established term (e.g. see [1]), and as I mentioned in the
context you dropped we don't spell out what NVMe or SPI stands for
either.

> Except that most people know GNSS as GPS. You misnamed the subsystem,
> so it now needs explanation :-(.

No, naming it GPS would have been too specific as these receivers are
not just for GPS.

Either way, this is about not cluttering up menuconfig and making that
harder to navigate for no good reason.

Johan

[1] https://www.u-blox.com/en/positioning-chips-and-modules

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]