* Re: [PATCH net-next V8 2/2] ptp: fix corrupted list in ptp_open
[not found] ` <tencent_1372C3B5244E7768777606C0F36563612905@qq.com>
@ 2023-11-07 6:13 ` Richard Cochran
0 siblings, 0 replies; only message in thread
From: Richard Cochran @ 2023-11-07 6:13 UTC (permalink / raw)
To: Edward Adam Davis
Cc: davem, habetsm.xilinx, jeremy, linux-kernel, netdev, reibax,
syzbot+df3f3ef31f60781fa911
On Mon, Nov 06, 2023 at 10:31:28PM +0800, Edward Adam Davis wrote:
> There is no lock protection when writing ptp->tsevqs in ptp_open() and
> ptp_release(), which can cause data corruption, use spin lock to avoid this
> issue.
>
> Moreover, ptp_release() should not be used to release the queue in ptp_read(),
> and it should be deleted altogether.
>
> Reported-and-tested-by: syzbot+df3f3ef31f60781fa911@syzkaller.appspotmail.com
> Fixes: 8f5de6fb2453 ("ptp: support multiple timestamp event readers")
> Signed-off-by: Edward Adam Davis <eadavis@qq.com>
(This should go to net and not net-next.)
Acked-by: Richard Cochran <richardcochran@gmail.com>
^ permalink raw reply [flat|nested] only message in thread