* [PATCH] USB: serial: option: modify Fibocom to DELL custom modem FM101R-GL
@ 2023-10-26 12:35 Puliang Lu
2023-11-21 13:25 ` Johan Hovold
0 siblings, 1 reply; 6+ messages in thread
From: Puliang Lu @ 2023-10-26 12:35 UTC (permalink / raw)
To: johan; +Cc: gregkh, linux-usb, linux-kernel, Puliang Lu
Modify the definition of Fibocom USB serial option driver
FM101R-GL different variants
- VID:PID 413C:8213, FM101R-GL ESIM are laptop M.2 cards (with
MBIM interfaces for Linux)
- VID:PID 413C:8215, FM101R-GL are laptop M.2 cards (with
MBIM interface for Linux)
0x8213: mbim, tty
0x8215: mbim, tty
Signed-off-by: Puliang Lu <puliang.lu@fibocom.com>
---
drivers/usb/serial/option.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 45dcfaadaf98..3aa219275509 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -203,8 +203,8 @@ static void option_instat_callback(struct urb *urb);
#define DELL_PRODUCT_5829E_ESIM 0x81e4
#define DELL_PRODUCT_5829E 0x81e6
-#define DELL_PRODUCT_FM101R 0x8213
-#define DELL_PRODUCT_FM101R_ESIM 0x8215
+#define DELL_PRODUCT_FM101R_ESIM 0x8213
+#define DELL_PRODUCT_FM101R 0x8215
#define KYOCERA_VENDOR_ID 0x0c88
#define KYOCERA_PRODUCT_KPC650 0x17da
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] USB: serial: option: modify Fibocom to DELL custom modem FM101R-GL
2023-10-26 12:35 [PATCH] USB: serial: option: modify Fibocom to DELL custom modem FM101R-GL Puliang Lu
@ 2023-11-21 13:25 ` Johan Hovold
0 siblings, 0 replies; 6+ messages in thread
From: Johan Hovold @ 2023-11-21 13:25 UTC (permalink / raw)
To: Puliang Lu; +Cc: gregkh, linux-usb, linux-kernel
On Thu, Oct 26, 2023 at 08:35:06PM +0800, Puliang Lu wrote:
> Modify the definition of Fibocom USB serial option driver
> FM101R-GL different variants
>
> - VID:PID 413C:8213, FM101R-GL ESIM are laptop M.2 cards (with
> MBIM interfaces for Linux)
>
> - VID:PID 413C:8215, FM101R-GL are laptop M.2 cards (with
> MBIM interface for Linux)
>
> 0x8213: mbim, tty
> 0x8215: mbim, tty
>
> Signed-off-by: Puliang Lu <puliang.lu@fibocom.com>
> -#define DELL_PRODUCT_FM101R 0x8213
> -#define DELL_PRODUCT_FM101R_ESIM 0x8215
> +#define DELL_PRODUCT_FM101R_ESIM 0x8213
> +#define DELL_PRODUCT_FM101R 0x8215
You have an extra tab here so that the values are no longer aligned.
>
> #define KYOCERA_VENDOR_ID 0x0c88
> #define KYOCERA_PRODUCT_KPC650 0x17da
Now applied with a slightly updated commit message:
https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-linus&id=a1092619dd28ac0fcf23016160a2fdccd98ef935
Johan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] USB: serial: option: modify Fibocom to DELL custom modem FM101R-GL
@ 2023-11-22 2:01 Puliang Lu(Puliang)
0 siblings, 0 replies; 6+ messages in thread
From: Puliang Lu(Puliang) @ 2023-11-22 2:01 UTC (permalink / raw)
To: Johan Hovold; +Cc: gregkh, linux-usb, linux-kernel
> Now applied with a slightly updated commit message:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-linus&id=a1092619dd28ac0fcf23016160a2fdccd98ef935
Thank you very much.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] USB: serial: option: modify Fibocom to DELL custom modem FM101R-GL
2023-11-15 4:11 Puliang Lu(Puliang)
@ 2023-11-15 7:05 ` Johan Hovold
0 siblings, 0 replies; 6+ messages in thread
From: Johan Hovold @ 2023-11-15 7:05 UTC (permalink / raw)
To: Puliang Lu(Puliang); +Cc: gregkh, linux-usb, linux-kernel
On Wed, Nov 15, 2023 at 04:11:02AM +0000, Puliang Lu(Puliang) wrote:
>
> > > Modify the definition of Fibocom USB serial option driver FM101R-GL different variants
> > >
> > > - VID:PID 413C:8213, FM101R-GL ESIM are laptop M.2 cards (with
> > > MBIM interfaces for Linux)
> > >
> > > - VID:PID 413C:8215, FM101R-GL are laptop M.2 cards (with
> > > MBIM interface for Linux)
> > >
> > > 0x8213: mbim, tty
> > > 0x8215: mbim, tty
> > >
> > > Signed-off-by: Puliang Lu <puliang.lu@fibocom.com>
> > > ---
> May I ask when this patch can be merged?
It's still in my queue and I haven't really looked at it yet. But don't
worry, it's not lost.
Johan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] USB: serial: option: modify Fibocom to DELL custom modem FM101R-GL
@ 2023-11-15 4:11 Puliang Lu(Puliang)
2023-11-15 7:05 ` Johan Hovold
0 siblings, 1 reply; 6+ messages in thread
From: Puliang Lu(Puliang) @ 2023-11-15 4:11 UTC (permalink / raw)
To: johan; +Cc: gregkh, linux-usb, linux-kernel
> > Modify the definition of Fibocom USB serial option driver FM101R-GL different variants
> >
> > - VID:PID 413C:8213, FM101R-GL ESIM are laptop M.2 cards (with
> > MBIM interfaces for Linux)
> >
> > - VID:PID 413C:8215, FM101R-GL are laptop M.2 cards (with
> > MBIM interface for Linux)
> >
> > 0x8213: mbim, tty
> > 0x8215: mbim, tty
> >
> > Signed-off-by: Puliang Lu <puliang.lu@fibocom.com>
> > ---
> > drivers/usb/serial/option.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 45dcfaadaf98..3aa219275509 100644
> > --- a/drivers/usb/serial/option.c
> > +++ b/drivers/usb/serial/option.c
> > @@ -203,8 +203,8 @@ static void option_instat_callback(struct urb *urb);
> > #define DELL_PRODUCT_5829E_ESIM 0x81e4
> > #define DELL_PRODUCT_5829E 0x81e6
> >
> > -#define DELL_PRODUCT_FM101R 0x8213
> > -#define DELL_PRODUCT_FM101R_ESIM 0x8215
> > +#define DELL_PRODUCT_FM101R_ESIM 0x8213
> > +#define DELL_PRODUCT_FM101R 0x8215
> >
> > #define KYOCERA_VENDOR_ID 0x0c88
> > #define KYOCERA_PRODUCT_KPC650 0x17da
> > --
> > 2.34.1
>
> Thank you for your feedback.
> We apologize for any mistake and have now submitted the
> incremental fix. Your input is greatly appreciated.
Hi johan,
May I ask when this patch can be merged?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] USB: serial: option: modify Fibocom to DELL custom modem FM101R-GL
@ 2023-10-26 12:47 Puliang Lu(Puliang)
0 siblings, 0 replies; 6+ messages in thread
From: Puliang Lu(Puliang) @ 2023-10-26 12:47 UTC (permalink / raw)
To: johan; +Cc: gregkh, linux-usb, linux-kernel
> Modify the definition of Fibocom USB serial option driver FM101R-GL different variants
>
> - VID:PID 413C:8213, FM101R-GL ESIM are laptop M.2 cards (with
> MBIM interfaces for Linux)
>
> - VID:PID 413C:8215, FM101R-GL are laptop M.2 cards (with
> MBIM interface for Linux)
>
> 0x8213: mbim, tty
> 0x8215: mbim, tty
>
> Signed-off-by: Puliang Lu <puliang.lu@fibocom.com>
> ---
> drivers/usb/serial/option.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 45dcfaadaf98..3aa219275509 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -203,8 +203,8 @@ static void option_instat_callback(struct urb *urb);
> #define DELL_PRODUCT_5829E_ESIM 0x81e4
> #define DELL_PRODUCT_5829E 0x81e6
>
> -#define DELL_PRODUCT_FM101R 0x8213
> -#define DELL_PRODUCT_FM101R_ESIM 0x8215
> +#define DELL_PRODUCT_FM101R_ESIM 0x8213
> +#define DELL_PRODUCT_FM101R 0x8215
>
> #define KYOCERA_VENDOR_ID 0x0c88
> #define KYOCERA_PRODUCT_KPC650 0x17da
> --
> 2.34.1
Thank you for your feedback.
We apologize for any mistake and have now submitted the
incremental fix. Your input is greatly appreciated.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-11-22 2:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-26 12:35 [PATCH] USB: serial: option: modify Fibocom to DELL custom modem FM101R-GL Puliang Lu
2023-11-21 13:25 ` Johan Hovold
2023-10-26 12:47 Puliang Lu(Puliang)
2023-11-15 4:11 Puliang Lu(Puliang)
2023-11-15 7:05 ` Johan Hovold
2023-11-22 2:01 Puliang Lu(Puliang)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®