From: Liviu Dudau <liviu.dudau@arm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: juno: align thermal zone names with bindings
Date: Mon, 11 Dec 2023 10:27:06 +0000 [thread overview]
Message-ID: <ZXbj-jRJcpzam0wG@e110455-lin.cambridge.arm.com> (raw)
In-Reply-To: <20231209171612.250868-1-krzysztof.kozlowski@linaro.org>
On Sat, Dec 09, 2023 at 06:16:12PM +0100, Krzysztof Kozlowski wrote:
> Thermal bindings require thermal zone node names to match
> certain patterns:
>
> juno.dtb: thermal-zones: 'big-cluster', 'gpu0', 'gpu1', 'little-cluster', 'pmic', 'soc'
> do not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Thanks for fixing this!
Best regards,
Liviu
> ---
> arch/arm64/boot/dts/arm/juno-base.dtsi | 12 ++++++------
> arch/arm64/boot/dts/arm/juno-scmi.dtsi | 12 ++++++------
> 2 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> index 8b4d280b1e7e..b897f5542c0a 100644
> --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> @@ -747,7 +747,7 @@ scpi_sensors0: sensors {
> };
>
> thermal-zones {
> - pmic {
> + pmic-thermal {
> polling-delay = <1000>;
> polling-delay-passive = <100>;
> thermal-sensors = <&scpi_sensors0 0>;
> @@ -760,7 +760,7 @@ pmic_crit0: trip0 {
> };
> };
>
> - soc {
> + soc-thermal {
> polling-delay = <1000>;
> polling-delay-passive = <100>;
> thermal-sensors = <&scpi_sensors0 3>;
> @@ -773,28 +773,28 @@ soc_crit0: trip0 {
> };
> };
>
> - big_cluster_thermal_zone: big-cluster {
> + big_cluster_thermal_zone: big-cluster-thermal {
> polling-delay = <1000>;
> polling-delay-passive = <100>;
> thermal-sensors = <&scpi_sensors0 21>;
> status = "disabled";
> };
>
> - little_cluster_thermal_zone: little-cluster {
> + little_cluster_thermal_zone: little-cluster-thermal {
> polling-delay = <1000>;
> polling-delay-passive = <100>;
> thermal-sensors = <&scpi_sensors0 22>;
> status = "disabled";
> };
>
> - gpu0_thermal_zone: gpu0 {
> + gpu0_thermal_zone: gpu0-thermal {
> polling-delay = <1000>;
> polling-delay-passive = <100>;
> thermal-sensors = <&scpi_sensors0 23>;
> status = "disabled";
> };
>
> - gpu1_thermal_zone: gpu1 {
> + gpu1_thermal_zone: gpu1-thermal {
> polling-delay = <1000>;
> polling-delay-passive = <100>;
> thermal-sensors = <&scpi_sensors0 24>;
> diff --git a/arch/arm64/boot/dts/arm/juno-scmi.dtsi b/arch/arm64/boot/dts/arm/juno-scmi.dtsi
> index ec85cd2c733c..31929e2377d8 100644
> --- a/arch/arm64/boot/dts/arm/juno-scmi.dtsi
> +++ b/arch/arm64/boot/dts/arm/juno-scmi.dtsi
> @@ -76,27 +76,27 @@ scmi_sensors0: protocol@15 {
> };
>
> thermal-zones {
> - pmic {
> + pmic-thermal {
> thermal-sensors = <&scmi_sensors0 0>;
> };
>
> - soc {
> + soc-thermal {
> thermal-sensors = <&scmi_sensors0 3>;
> };
>
> - big-cluster {
> + big-cluster-thermal {
> thermal-sensors = <&scmi_sensors0 21>;
> };
>
> - little-cluster {
> + little-cluster-thermal {
> thermal-sensors = <&scmi_sensors0 22>;
> };
>
> - gpu0 {
> + gpu0-thermal {
> thermal-sensors = <&scmi_sensors0 23>;
> };
>
> - gpu1 {
> + gpu1-thermal {
> thermal-sensors = <&scmi_sensors0 24>;
> };
> };
> --
> 2.34.1
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
next prev parent reply other threads:[~2023-12-11 10:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 17:16 Krzysztof Kozlowski
2023-12-11 10:27 ` Liviu Dudau [this message]
2023-12-13 11:57 ` Sudeep Holla
2024-01-02 18:09 ` Rob Herring
2024-01-03 10:13 ` Krzysztof Kozlowski
2024-01-03 13:39 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXbj-jRJcpzam0wG@e110455-lin.cambridge.arm.com \
--to=liviu.dudau@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®