* [PATCH] drm/tegra: dsi: Add missing check for of_find_device_by_node
@ 2023-10-24 8:07 Chen Ni
2023-12-14 17:22 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Chen Ni @ 2023-10-24 8:07 UTC (permalink / raw)
To: thierry.reding, mperttunen, airlied, daniel, jonathanh
Cc: dri-devel, linux-tegra, linux-kernel, Chen Ni
Add check for the return value of of_find_device_by_node() and return
the error if it fails in order to avoid NULL pointer dereference.
Fixes: e94236cde4d5 ("drm/tegra: dsi: Add ganged mode support")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/gpu/drm/tegra/dsi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c
index a9870c828374..4101b2e01211 100644
--- a/drivers/gpu/drm/tegra/dsi.c
+++ b/drivers/gpu/drm/tegra/dsi.c
@@ -1543,9 +1543,11 @@ static int tegra_dsi_ganged_probe(struct tegra_dsi *dsi)
np = of_parse_phandle(dsi->dev->of_node, "nvidia,ganged-mode", 0);
if (np) {
struct platform_device *gangster = of_find_device_by_node(np);
+ of_node_put(np);
+ if (!gangster)
+ return -EPROBE_DEFER;
dsi->slave = platform_get_drvdata(gangster);
- of_node_put(np);
if (!dsi->slave) {
put_device(&gangster->dev);
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/tegra: dsi: Add missing check for of_find_device_by_node
2023-10-24 8:07 [PATCH] drm/tegra: dsi: Add missing check for of_find_device_by_node Chen Ni
@ 2023-12-14 17:22 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2023-12-14 17:22 UTC (permalink / raw)
To: Chen Ni
Cc: mperttunen, airlied, daniel, jonathanh, dri-devel, linux-tegra,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 448 bytes --]
On Tue, Oct 24, 2023 at 08:07:38AM +0000, Chen Ni wrote:
> Add check for the return value of of_find_device_by_node() and return
> the error if it fails in order to avoid NULL pointer dereference.
>
> Fixes: e94236cde4d5 ("drm/tegra: dsi: Add ganged mode support")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/gpu/drm/tegra/dsi.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-14 17:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-24 8:07 [PATCH] drm/tegra: dsi: Add missing check for of_find_device_by_node Chen Ni
2023-12-14 17:22 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®