mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH v2 3/4] drm/i915/guc: reconcile Excess struct member kernel-doc warnings
Date: Thu, 28 Dec 2023 17:40:44 +0100	[thread overview]
Message-ID: <ZY2lDJ4BkwO1AZGj@ashyti-mobl2.lan> (raw)
In-Reply-To: <20231226195432.10891-3-rdunlap@infradead.org>

Hi Randy,

[...]

> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> @@ -105,61 +105,67 @@ struct intel_guc {
>  	 */


struct { } interrupts is missing here.

>  	struct {
>  		/**
> -		 * @lock: protects everything in submission_state,
> -		 * ce->guc_id.id, and ce->guc_id.ref when transitioning in and

[...]

> +		 * we start bypassing the schedule disable delay
>  		 */
>  		unsigned int sched_disable_gucid_threshold;
>  	} submission_state;

Here struct { } send_regs is missing

But as for this patch:

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Thanks,
Andi

>  	struct {
>  		/**
> -		 * @lock: Lock protecting the below fields and the engine stats.
> +		 * @timestamp.lock: Lock protecting the below fields and

[...]

  reply	other threads:[~2023-12-28 16:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-26 19:54 [PATCH v2 1/4] drm/i915/gem: " Randy Dunlap
2023-12-26 19:54 ` [PATCH v2 2/4] drm/i915/gt: " Randy Dunlap
2023-12-28 16:25   ` Andi Shyti
2023-12-28 23:42     ` Randy Dunlap
2023-12-26 19:54 ` [PATCH v2 3/4] drm/i915/guc: " Randy Dunlap
2023-12-28 16:40   ` Andi Shyti [this message]
2023-12-28 23:37     ` Randy Dunlap
2023-12-26 19:54 ` [PATCH v2 4/4] drm/i915/perf: " Randy Dunlap
2023-12-28 16:41   ` Andi Shyti
2023-12-28 16:21 ` [PATCH v2 1/4] drm/i915/gem: " Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZY2lDJ4BkwO1AZGj@ashyti-mobl2.lan \
    --to=andi.shyti@linux.intel.com \
    --cc=corbet@lwn.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®