* [PATCH] soc/tegra: fuse: Define tegra194_soc_attr_group for Tegra241
@ 2023-12-20 6:10 Kartik
2023-12-20 6:32 ` Randy Dunlap
2023-12-20 11:43 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Kartik @ 2023-12-20 6:10 UTC (permalink / raw)
To: rdunlap, sfr, thierry.reding, jonathanh, kkartik, frank.li,
linux-tegra, linux-kernel
Tegra241 SoC data uses tegra194_soc_attr_group, which is only defined
if config CONFIG_ARCH_TEGRA_194_SOC or CONFIG_ARCH_TEGRA_234_SOC or
both are enabled. This causes a build failure if both of these configs
are disabled and CONFIG_ARCH_TEGRA_241_SOC is enabled.
Define tegra194_soc_attr_group if CONFIG_ARCH_TEGRA_241_SOC is enabled.
Signed-off-by: Kartik <kkartik@nvidia.com>
---
drivers/soc/tegra/fuse/fuse-tegra.c | 3 ++-
drivers/soc/tegra/fuse/fuse.h | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c b/drivers/soc/tegra/fuse/fuse-tegra.c
index 233b8e7bb41b..c34efa5bf44c 100644
--- a/drivers/soc/tegra/fuse/fuse-tegra.c
+++ b/drivers/soc/tegra/fuse/fuse-tegra.c
@@ -407,7 +407,8 @@ const struct attribute_group tegra_soc_attr_group = {
};
#if IS_ENABLED(CONFIG_ARCH_TEGRA_194_SOC) || \
- IS_ENABLED(CONFIG_ARCH_TEGRA_234_SOC)
+ IS_ENABLED(CONFIG_ARCH_TEGRA_234_SOC) || \
+ IS_ENABLED(CONFIG_ARCH_TEGRA_241_SOC)
static ssize_t platform_show(struct device *dev, struct device_attribute *attr,
char *buf)
{
diff --git a/drivers/soc/tegra/fuse/fuse.h b/drivers/soc/tegra/fuse/fuse.h
index f3b705327c20..9fee6ad6ad9e 100644
--- a/drivers/soc/tegra/fuse/fuse.h
+++ b/drivers/soc/tegra/fuse/fuse.h
@@ -124,7 +124,8 @@ extern const struct tegra_fuse_soc tegra186_fuse_soc;
#endif
#if IS_ENABLED(CONFIG_ARCH_TEGRA_194_SOC) || \
- IS_ENABLED(CONFIG_ARCH_TEGRA_234_SOC)
+ IS_ENABLED(CONFIG_ARCH_TEGRA_234_SOC) || \
+ IS_ENABLED(CONFIG_ARCH_TEGRA_241_SOC)
extern const struct attribute_group tegra194_soc_attr_group;
#endif
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc/tegra: fuse: Define tegra194_soc_attr_group for Tegra241
2023-12-20 6:10 [PATCH] soc/tegra: fuse: Define tegra194_soc_attr_group for Tegra241 Kartik
@ 2023-12-20 6:32 ` Randy Dunlap
2023-12-20 11:43 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2023-12-20 6:32 UTC (permalink / raw)
To: Kartik, sfr, thierry.reding, jonathanh, frank.li, linux-tegra,
linux-kernel
On 12/19/23 22:10, Kartik wrote:
> Tegra241 SoC data uses tegra194_soc_attr_group, which is only defined
> if config CONFIG_ARCH_TEGRA_194_SOC or CONFIG_ARCH_TEGRA_234_SOC or
> both are enabled. This causes a build failure if both of these configs
> are disabled and CONFIG_ARCH_TEGRA_241_SOC is enabled.
>
> Define tegra194_soc_attr_group if CONFIG_ARCH_TEGRA_241_SOC is enabled.
>
> Signed-off-by: Kartik <kkartik@nvidia.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> drivers/soc/tegra/fuse/fuse-tegra.c | 3 ++-
> drivers/soc/tegra/fuse/fuse.h | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c b/drivers/soc/tegra/fuse/fuse-tegra.c
> index 233b8e7bb41b..c34efa5bf44c 100644
> --- a/drivers/soc/tegra/fuse/fuse-tegra.c
> +++ b/drivers/soc/tegra/fuse/fuse-tegra.c
> @@ -407,7 +407,8 @@ const struct attribute_group tegra_soc_attr_group = {
> };
>
> #if IS_ENABLED(CONFIG_ARCH_TEGRA_194_SOC) || \
> - IS_ENABLED(CONFIG_ARCH_TEGRA_234_SOC)
> + IS_ENABLED(CONFIG_ARCH_TEGRA_234_SOC) || \
> + IS_ENABLED(CONFIG_ARCH_TEGRA_241_SOC)
> static ssize_t platform_show(struct device *dev, struct device_attribute *attr,
> char *buf)
> {
> diff --git a/drivers/soc/tegra/fuse/fuse.h b/drivers/soc/tegra/fuse/fuse.h
> index f3b705327c20..9fee6ad6ad9e 100644
> --- a/drivers/soc/tegra/fuse/fuse.h
> +++ b/drivers/soc/tegra/fuse/fuse.h
> @@ -124,7 +124,8 @@ extern const struct tegra_fuse_soc tegra186_fuse_soc;
> #endif
>
> #if IS_ENABLED(CONFIG_ARCH_TEGRA_194_SOC) || \
> - IS_ENABLED(CONFIG_ARCH_TEGRA_234_SOC)
> + IS_ENABLED(CONFIG_ARCH_TEGRA_234_SOC) || \
> + IS_ENABLED(CONFIG_ARCH_TEGRA_241_SOC)
> extern const struct attribute_group tegra194_soc_attr_group;
> #endif
>
--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc/tegra: fuse: Define tegra194_soc_attr_group for Tegra241
2023-12-20 6:10 [PATCH] soc/tegra: fuse: Define tegra194_soc_attr_group for Tegra241 Kartik
2023-12-20 6:32 ` Randy Dunlap
@ 2023-12-20 11:43 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2023-12-20 11:43 UTC (permalink / raw)
To: Kartik; +Cc: rdunlap, sfr, jonathanh, frank.li, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 649 bytes --]
On Wed, Dec 20, 2023 at 11:40:13AM +0530, Kartik wrote:
> Tegra241 SoC data uses tegra194_soc_attr_group, which is only defined
> if config CONFIG_ARCH_TEGRA_194_SOC or CONFIG_ARCH_TEGRA_234_SOC or
> both are enabled. This causes a build failure if both of these configs
> are disabled and CONFIG_ARCH_TEGRA_241_SOC is enabled.
>
> Define tegra194_soc_attr_group if CONFIG_ARCH_TEGRA_241_SOC is enabled.
>
> Signed-off-by: Kartik <kkartik@nvidia.com>
> ---
> drivers/soc/tegra/fuse/fuse-tegra.c | 3 ++-
> drivers/soc/tegra/fuse/fuse.h | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-20 11:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-20 6:10 [PATCH] soc/tegra: fuse: Define tegra194_soc_attr_group for Tegra241 Kartik
2023-12-20 6:32 ` Randy Dunlap
2023-12-20 11:43 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®