* [PATCH v2] kdump: Remove redundant DEFAULT_CRASH_KERNEL_LOW_SIZE
@ 2023-12-26 23:46 Youling Tang
2023-12-27 0:46 ` Baoquan He
0 siblings, 1 reply; 2+ messages in thread
From: Youling Tang @ 2023-12-26 23:46 UTC (permalink / raw)
To: Baoquan He; +Cc: Huacai Chen, linux-kernel, Youling Tang
From: Youling Tang <tangyouling@kylinos.cn>
Remove duplicate definitions, no functional changes.
Reported-by: Huacai Chen <chenhuacai@loongson.cn>
Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
---
include/linux/crash_core.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/include/linux/crash_core.h b/include/linux/crash_core.h
index 5126a4fecb44..9eaeaafe0cad 100644
--- a/include/linux/crash_core.h
+++ b/include/linux/crash_core.h
@@ -87,12 +87,6 @@ Elf_Word *append_elf_note(Elf_Word *buf, char *name, unsigned int type,
void *data, size_t data_len);
void final_note(Elf_Word *buf);
-#ifdef CONFIG_ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
-#ifndef DEFAULT_CRASH_KERNEL_LOW_SIZE
-#define DEFAULT_CRASH_KERNEL_LOW_SIZE (128UL << 20)
-#endif
-#endif
-
int __init parse_crashkernel(char *cmdline, unsigned long long system_ram,
unsigned long long *crash_size, unsigned long long *crash_base,
unsigned long long *low_size, bool *high);
--
2.40.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] kdump: Remove redundant DEFAULT_CRASH_KERNEL_LOW_SIZE
2023-12-26 23:46 [PATCH v2] kdump: Remove redundant DEFAULT_CRASH_KERNEL_LOW_SIZE Youling Tang
@ 2023-12-27 0:46 ` Baoquan He
0 siblings, 0 replies; 2+ messages in thread
From: Baoquan He @ 2023-12-27 0:46 UTC (permalink / raw)
To: Youling Tang, akpm; +Cc: Huacai Chen, linux-kernel, Youling Tang
On 12/27/23 at 07:46am, Youling Tang wrote:
> From: Youling Tang <tangyouling@kylinos.cn>
>
> Remove duplicate definitions, no functional changes.
>
> Reported-by: Huacai Chen <chenhuacai@loongson.cn>
> Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
> ---
> include/linux/crash_core.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/include/linux/crash_core.h b/include/linux/crash_core.h
> index 5126a4fecb44..9eaeaafe0cad 100644
> --- a/include/linux/crash_core.h
> +++ b/include/linux/crash_core.h
> @@ -87,12 +87,6 @@ Elf_Word *append_elf_note(Elf_Word *buf, char *name, unsigned int type,
> void *data, size_t data_len);
> void final_note(Elf_Word *buf);
>
> -#ifdef CONFIG_ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
> -#ifndef DEFAULT_CRASH_KERNEL_LOW_SIZE
> -#define DEFAULT_CRASH_KERNEL_LOW_SIZE (128UL << 20)
> -#endif
> -#endif
Good catch, thx.
Acked-by: Baoquan He <bhe@redhat.com>
> -
> int __init parse_crashkernel(char *cmdline, unsigned long long system_ram,
> unsigned long long *crash_size, unsigned long long *crash_base,
> unsigned long long *low_size, bool *high);
> --
> 2.40.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-27 0:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-26 23:46 [PATCH v2] kdump: Remove redundant DEFAULT_CRASH_KERNEL_LOW_SIZE Youling Tang
2023-12-27 0:46 ` Baoquan He
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®