* [PATCH v1] devres: simplify devm_kstrdup() using devm_kmemdup()
@ 2025-04-07 12:13 Raag Jadav
2025-04-07 13:40 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Raag Jadav @ 2025-04-07 12:13 UTC (permalink / raw)
To: gregkh, rafael, dakr, andriy.shevchenko; +Cc: linux-kernel, Raag Jadav
devm_kstrdup() logic pretty much reflects devm_kmemdup() for strings,
so just reuse it.
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
drivers/base/devres.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/base/devres.c b/drivers/base/devres.c
index d8a733ea5e1a..82fdc1c55045 100644
--- a/drivers/base/devres.c
+++ b/drivers/base/devres.c
@@ -976,17 +976,7 @@ EXPORT_SYMBOL_GPL(devm_krealloc);
*/
char *devm_kstrdup(struct device *dev, const char *s, gfp_t gfp)
{
- size_t size;
- char *buf;
-
- if (!s)
- return NULL;
-
- size = strlen(s) + 1;
- buf = devm_kmalloc(dev, size, gfp);
- if (buf)
- memcpy(buf, s, size);
- return buf;
+ return s ? devm_kmemdup(dev, s, strlen(s) + 1, gfp) : NULL;
}
EXPORT_SYMBOL_GPL(devm_kstrdup);
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v1] devres: simplify devm_kstrdup() using devm_kmemdup()
2025-04-07 12:13 [PATCH v1] devres: simplify devm_kstrdup() using devm_kmemdup() Raag Jadav
@ 2025-04-07 13:40 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2025-04-07 13:40 UTC (permalink / raw)
To: Raag Jadav; +Cc: gregkh, rafael, dakr, linux-kernel
On Mon, Apr 07, 2025 at 05:43:11PM +0530, Raag Jadav wrote:
> devm_kstrdup() logic pretty much reflects devm_kmemdup() for strings,
> so just reuse it.
...
> char *devm_kstrdup(struct device *dev, const char *s, gfp_t gfp)
> {
> - size_t size;
> - char *buf;
> - if (!s)
> - return NULL;
There is no point to touch these lines.
And this is the style used in the file elsewhere.
> - size = strlen(s) + 1;
> - buf = devm_kmalloc(dev, size, gfp);
> - if (buf)
> - memcpy(buf, s, size);
> - return buf;
> + return s ? devm_kmemdup(dev, s, strlen(s) + 1, gfp) : NULL;
> }
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-07 13:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-07 12:13 [PATCH v1] devres: simplify devm_kstrdup() using devm_kmemdup() Raag Jadav
2025-04-07 13:40 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®