mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: "Mario Limonciello" <superm1@kernel.org>,
	"Borislav Petkov" <bp@alien8.de>,
	"Jean Delvare" <jdelvare@suse.com>,
	"Andi Shyti" <andi.shyti@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
	Mario Limonciello <mario.limonciello@amd.com>,
	Yazen Ghannam <yazen.ghannam@amd.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
	<x86@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
	Hans de Goede <hdegoede@redhat.com>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:I2C/SMBUS CONTROLLER DRIVERS FOR PC"
	<linux-i2c@vger.kernel.org>,
	"open list:AMD PMC DRIVER" <platform-driver-x86@vger.kernel.org>,
	"Gautham R . Shenoy" <gautham.shenoy@amd.com>
Subject: Re: [PATCH v3 1/4] Documentation: Add AMD Zen debugging document
Date: Sat, 12 Apr 2025 09:28:44 +0700	[thread overview]
Message-ID: <Z_nP3FGEZzvRf26g@archie.me> (raw)
In-Reply-To: <8497954e-38de-43f5-b3e9-f354c308289e@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 3052 bytes --]

On Fri, Apr 11, 2025 at 09:19:09PM -0500, Mario Limonciello wrote:
> 
> 
> On 4/11/25 21:12, Bagas Sanjaya wrote:
> > On Thu, Apr 10, 2025 at 03:01:59PM -0500, Mario Limonciello wrote:
> > > v3:
> > >   * Move debugging.rst to index.rst
> > 
> > Do you plan to add more AMD-specific admin docs in the future?
> 
> I don't have any others planned right now.  That move was because I noticed
> a toc warning with how I had it structured before.
> 
> > (BTW, I don't
> > follow v2 discussions.)
> 
> Don't worry; documentation hasn't been talked about in v2, it's all been
> discussion on the S5_RESET_STATUS.

Understand.

> 
> > 
> > > +As there are a lot of places that problems can occur, a debugging script has
> > > +been created that can help test for common problems and offer suggestions.
> > > +
> > > +https://git.kernel.org/pub/scm/linux/kernel/git/superm1/amd-debug-tools.git/tree/amd_s2idle.py
> > > +
> > > +If you have an s2idle issue, it's best to start with this and follow instructions
> > > +from its findings.  If you continue to have an issue, raise a bug with the
> > > +report generated from this script.
> > 
> > To mailing list following Documentation/admin-guide/reporting-issues.rst?
> 
> Actually I prefer them to drm/amd with the s2idle bug template.  I'll add
> this detail.
> 
> > 
> > > +First convert the GPIO number into hex. ::
> > > +
> > > +  $ python3 -c "print(hex(59))"
> > > +  0x3b
> > > +
> > > +Next determine which ACPI table has the ``_EVT`` entry. For example: ::
> > > +
> > > +  $ sudo grep EVT /sys/firmware/acpi/tables/SSDT*
> > > +  grep: /sys/firmware/acpi/tables/SSDT27: binary file matches
> > > +
> > > +Decode this table:::
> > > +
> > > +  $ sudo cp /sys/firmware/acpi/tables/SSDT27 .
> > > +  $ sudo iasl -d SSDT27
> > 
> > Nit: two colons are sufficient for literal code-block.
> 
> Thanks.
> 
> > 
> > > +To activate PM debugging, use the kernel command line option: ``pm_debug_messages``.
> > > +
> > > +Or enable the feature using the sysfs file: ``/sys/power/pm_debug_messages``
> > > +Constraints that are not met will be displayed in the kernel log and can be
> > > +viewed using anything that processes the kernel ring buffer such as ``dmesg``` or
> > > +``journalctl``.
> > 
> > "To activate PM debugging, either specify ``pm_debug_messagess`` kernel
> > command-line option at boot or write to ``/sys/power/pm_debug_messages``.
> > Unmet constraints will be displayed in the kernel log and can be
> > viewed by logging tools that process kernel ring buffer like dmesg or
> > journalctl."
> > 
> > > +`patch <https://lore.kernel.org/amd-gfx/20250305051402.1550046-3-chiahsuan.chung@amd.com/T/#u>`_
> > 
> > What about that patchset status? It was not reviewed by upstream maintainers,
> > right?
> > 
> 
> At the time I wrote this document it wasn't yet merged.  It's been since
> merged, I will update to the commit details.
> 

OK, thanks!

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2025-04-12  2:28 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-10 20:01 [PATCH v3 0/4] AMD Zen debugging documentation Mario Limonciello
2025-04-10 20:01 ` [PATCH v3 1/4] Documentation: Add AMD Zen debugging document Mario Limonciello
2025-04-12  2:12   ` Bagas Sanjaya
2025-04-12  2:19     ` Mario Limonciello
2025-04-12  2:28       ` Bagas Sanjaya [this message]
2025-04-10 20:02 ` [PATCH v3 2/4] i2c: piix4: Move SB800_PIIX4_FCH_PM_ADDR definition to amd_node.h Mario Limonciello
2025-04-11 11:49   ` Borislav Petkov
2025-04-11 12:09     ` Mario Limonciello
2025-04-11 12:41       ` Borislav Petkov
2025-04-12 19:44         ` Ingo Molnar
2025-04-12 19:51           ` Mario Limonciello
2025-04-12 20:15             ` Ingo Molnar
2025-04-12 20:23               ` Mario Limonciello
2025-04-12 20:47                 ` Ingo Molnar
2025-04-12 22:29               ` Borislav Petkov
2025-04-13  7:54                 ` Ingo Molnar
2025-04-13  8:44                   ` Ingo Molnar
2025-04-13 19:27                     ` Mario Limonciello
2025-04-13 19:32                       ` Ingo Molnar
2025-04-11 21:15   ` kernel test robot
2025-04-11 21:56   ` kernel test robot
2025-04-10 20:02 ` [PATCH v3 3/4] platform/x86/amd: pmc: use FCH_PM_BASE definition Mario Limonciello
2025-04-10 20:02 ` [PATCH v3 4/4] x86/CPU/AMD: Print the reason for the last reset Mario Limonciello
2025-04-11 12:06   ` Borislav Petkov
2025-04-11 12:12     ` Mario Limonciello
2025-04-11 12:50       ` Borislav Petkov
2025-04-11 13:25         ` Mario Limonciello
2025-04-12 19:37       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z_nP3FGEZzvRf26g@archie.me \
    --to=bagasdotme@gmail.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=andi.shyti@kernel.org \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=gautham.shenoy@amd.com \
    --cc=hdegoede@redhat.com \
    --cc=hpa@zytor.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jdelvare@suse.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mingo@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=superm1@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®