* [PATCH] MIPS: Cobalt: Fix missing prototypes
@ 2024-01-17 4:30 Florian Fainelli
2024-01-22 10:13 ` Thomas Bogendoerfer
0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2024-01-17 4:30 UTC (permalink / raw)
To: linux-mips; +Cc: Florian Fainelli, Thomas Bogendoerfer, open list
Fix missing prototypes warnings for cobalt_machine_halt() and
cobalt_machine_restart() by moving their prototypes to cobalt.h which is
included by setup.c.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/mips/cobalt/setup.c | 3 ---
arch/mips/include/asm/mach-cobalt/cobalt.h | 3 +++
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/mips/cobalt/setup.c b/arch/mips/cobalt/setup.c
index 2e099d55a564..9a266bf78339 100644
--- a/arch/mips/cobalt/setup.c
+++ b/arch/mips/cobalt/setup.c
@@ -23,9 +23,6 @@
#include <cobalt.h>
-extern void cobalt_machine_restart(char *command);
-extern void cobalt_machine_halt(void);
-
const char *get_system_type(void)
{
switch (cobalt_board_id) {
diff --git a/arch/mips/include/asm/mach-cobalt/cobalt.h b/arch/mips/include/asm/mach-cobalt/cobalt.h
index 5b9fce73f11d..97f9d5e9446d 100644
--- a/arch/mips/include/asm/mach-cobalt/cobalt.h
+++ b/arch/mips/include/asm/mach-cobalt/cobalt.h
@@ -19,4 +19,7 @@ extern int cobalt_board_id;
#define COBALT_BRD_ID_QUBE2 0x5
#define COBALT_BRD_ID_RAQ2 0x6
+void cobalt_machine_halt(void);
+void cobalt_machine_restart(char *command);
+
#endif /* __ASM_COBALT_H */
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: Cobalt: Fix missing prototypes
2024-01-17 4:30 [PATCH] MIPS: Cobalt: Fix missing prototypes Florian Fainelli
@ 2024-01-22 10:13 ` Thomas Bogendoerfer
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Bogendoerfer @ 2024-01-22 10:13 UTC (permalink / raw)
To: Florian Fainelli; +Cc: linux-mips, open list
On Tue, Jan 16, 2024 at 08:30:59PM -0800, Florian Fainelli wrote:
> Fix missing prototypes warnings for cobalt_machine_halt() and
> cobalt_machine_restart() by moving their prototypes to cobalt.h which is
> included by setup.c.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> arch/mips/cobalt/setup.c | 3 ---
> arch/mips/include/asm/mach-cobalt/cobalt.h | 3 +++
> 2 files changed, 3 insertions(+), 3 deletions(-)
applied to mips-fixes
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-22 10:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-17 4:30 [PATCH] MIPS: Cobalt: Fix missing prototypes Florian Fainelli
2024-01-22 10:13 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®