* [PATCH] x86/alternatives: Fix switch block in apply_reloc()
@ 2024-01-22 13:15 Pranav Athreya
2024-01-22 13:20 ` Borislav Petkov
0 siblings, 1 reply; 3+ messages in thread
From: Pranav Athreya @ 2024-01-22 13:15 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen, x86,
H. Peter Anvin, linux-kernel
Cc: Pranav Athreya
Adhere to Linux kernel coding style
Reported by checkpatch:
ERROR: trailing statements should be on next line
+ case 1: apply_reloc_n(8, ptr, diff); break;
ERROR: trailing statements should be on next line
+ case 2: apply_reloc_n(16, ptr, diff); break;
ERROR: trailing statements should be on next line
+ case 4: apply_reloc_n(32, ptr, diff); break;
ERROR: trailing statements should be on next line
+ default: BUG();
Signed-off-by: Pranav Athreya <pranavsubbu@gmail.com>
---
arch/x86/kernel/alternative.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
index ee0f681ae107..340cb5724d8f 100644
--- a/arch/x86/kernel/alternative.c
+++ b/arch/x86/kernel/alternative.c
@@ -297,10 +297,17 @@ static __always_inline
void apply_reloc(int n, void *ptr, uintptr_t diff)
{
switch (n) {
- case 1: apply_reloc_n(8, ptr, diff); break;
- case 2: apply_reloc_n(16, ptr, diff); break;
- case 4: apply_reloc_n(32, ptr, diff); break;
- default: BUG();
+ case 1:
+ apply_reloc_n(8, ptr, diff);
+ break;
+ case 2:
+ apply_reloc_n(16, ptr, diff);
+ break;
+ case 4:
+ apply_reloc_n(32, ptr, diff);
+ break;
+ default:
+ BUG();
}
}
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/alternatives: Fix switch block in apply_reloc()
2024-01-22 13:15 [PATCH] x86/alternatives: Fix switch block in apply_reloc() Pranav Athreya
@ 2024-01-22 13:20 ` Borislav Petkov
2024-01-22 13:25 ` Pranav Athreya
0 siblings, 1 reply; 3+ messages in thread
From: Borislav Petkov @ 2024-01-22 13:20 UTC (permalink / raw)
To: Pranav Athreya
Cc: Thomas Gleixner, Ingo Molnar, Dave Hansen, x86, H. Peter Anvin,
linux-kernel, Pranav Athreya
On Mon, Jan 22, 2024 at 06:45:27PM +0530, Pranav Athreya wrote:
> - case 1: apply_reloc_n(8, ptr, diff); break;
> - case 2: apply_reloc_n(16, ptr, diff); break;
> - case 4: apply_reloc_n(32, ptr, diff); break;
> - default: BUG();
It is more compact and faster readable this way. Do not always take what
checkpatch tells you to the letter.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/alternatives: Fix switch block in apply_reloc()
2024-01-22 13:20 ` Borislav Petkov
@ 2024-01-22 13:25 ` Pranav Athreya
0 siblings, 0 replies; 3+ messages in thread
From: Pranav Athreya @ 2024-01-22 13:25 UTC (permalink / raw)
To: Borislav Petkov
Cc: Thomas Gleixner, Ingo Molnar, Dave Hansen, x86, H. Peter Anvin,
linux-kernel
On Mon, Jan 22, 2024 at 6:51 PM Borislav Petkov <bp@alien8.de> wrote:
> It is more compact and faster readable this way. Do not always take what
> checkpatch tells you to the letter.
Understood. Thank you for the feedback, Boris.
Regards,
Pranav
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-22 13:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-22 13:15 [PATCH] x86/alternatives: Fix switch block in apply_reloc() Pranav Athreya
2024-01-22 13:20 ` Borislav Petkov
2024-01-22 13:25 ` Pranav Athreya
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®