From: Mark Brown <broonie@kernel.org>
To: Ben Wolsieffer <ben.wolsieffer@hefring.com>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] regmap: kunit: fix raw noinc write test wrapping
Date: Tue, 6 Feb 2024 15:38:27 +0000 [thread overview]
Message-ID: <ZcJSc595GcjDC4QK@finisterre.sirena.org.uk> (raw)
In-Reply-To: <20240206151004.1636761-2-ben.wolsieffer@hefring.com>
[-- Attachment #1: Type: text/plain, Size: 839 bytes --]
On Tue, Feb 06, 2024 at 10:10:05AM -0500, Ben Wolsieffer wrote:
> The raw noinc write test places a known value in the register following
> the noinc register to verify that it is not disturbed by the noinc
> write. This test ensures this value is distinct by adding 100 to the
> second element of the noinc write data.
>
> The regmap registers are 16-bit, while the test value is stored in an
> unsigned int. Therefore, adding 100 may cause the register to wrap while
> the test value does not, causing the test to fail. This patch fixes this
> by changing val_test and val_last from unsigned int to u16.
Ah, that'd do it! I wonder why Guenter is seeing this with much greater
frequency than I am, I have managed to reproduce a few times this
afternoon but very rarely. Guenter, does this fix the issues you're
seeing?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-02-06 15:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 15:10 Ben Wolsieffer
2024-02-06 15:38 ` Mark Brown [this message]
2024-02-06 16:43 ` Guenter Roeck
2024-02-06 16:47 ` Mark Brown
2024-02-06 17:37 ` Guenter Roeck
2024-02-07 18:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcJSc595GcjDC4QK@finisterre.sirena.org.uk \
--to=broonie@kernel.org \
--cc=ben.wolsieffer@hefring.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®