mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Ben Wolsieffer <ben.wolsieffer@hefring.com>,
	linux-kernel@vger.kernel.org
Cc: Mark Brown <broonie@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH] regmap: kunit: fix raw noinc write test wrapping
Date: Tue, 6 Feb 2024 09:37:32 -0800	[thread overview]
Message-ID: <a93ca301-243a-4e75-afa5-fdf80b20eb8f@roeck-us.net> (raw)
In-Reply-To: <20240206151004.1636761-2-ben.wolsieffer@hefring.com>

On 2/6/24 07:10, Ben Wolsieffer wrote:
> The raw noinc write test places a known value in the register following
> the noinc register to verify that it is not disturbed by the noinc
> write. This test ensures this value is distinct by adding 100 to the
> second element of the noinc write data.
> 
> The regmap registers are 16-bit, while the test value is stored in an
> unsigned int. Therefore, adding 100 may cause the register to wrap while
> the test value does not, causing the test to fail. This patch fixes this
> by changing val_test and val_last from unsigned int to u16.
> 
> Signed-off-by: Ben Wolsieffer <ben.wolsieffer@hefring.com>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Closes: https://lore.kernel.org/linux-kernel/745d3a11-15bc-48b6-84c8-c8761c943bed@roeck-us.net/T/

I no longer see the problem with this patch applied.

Tested-by: Guenter Roeck <linux@roeck-us.net>

Thanks,
Guenter


  parent reply	other threads:[~2024-02-06 17:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-06 15:10 Ben Wolsieffer
2024-02-06 15:38 ` Mark Brown
2024-02-06 16:43   ` Guenter Roeck
2024-02-06 16:47     ` Mark Brown
2024-02-06 17:37 ` Guenter Roeck [this message]
2024-02-07 18:20 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a93ca301-243a-4e75-afa5-fdf80b20eb8f@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=ben.wolsieffer@hefring.com \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®