Re: [PATCH] dt-bindings: usb: typec: anx7688: start a binding document

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 3694 bytes --]

Hi!
> > Add binding for anx7688 usb type-c bridge. I don't have a datasheet,
> > but I did best I could.
> > 
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > 
> 
> You miss proper diffstat which makes reviewing difficult.

> Actually entire patch is corrupted and impossible to apply.

Sorry about that.

> Anyway, where is any user of this? Nothing in commit msg explains
>  this.

User being is worked on:

https://lore.kernel.org/lkml/2024020126-emote-unsubtly-3394@gregkh/T/

Thanks for comments. I'll go through them and try to improve things.

Best regards,
								Pavel

> 
> > diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml b/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml
> > new file mode 100644
> > index 000000000000..b9d60586937f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml
> > @@ -0,0 +1,140 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/usb/analogix,anx7688.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analogix ANX7688 Type-C controller
> > +
> > +maintainers:
> > +  - Pavel Machek <pavel@ucw.cz>
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - analogix,anx7688
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  reset-gpios:
> > +    maxItems: 1
> 
> blank line
> 
> > +  enable-gpios:
> > +    maxItems: 1
> > +  cabledet-gpios:
> > +    maxItems: 1
> > +
> > +  avdd10-supply:
> > +    description:
> > +      1.0V power supply
> 
> Keep description in one line and add a blank line. This code is not that
> readable.
> 
> > +  dvdd10-supply:
> > +    description:
> > +      1.0V power supply
> > +  avdd18-supply:
> > +    description:
> > +      1.8V power supply
> > +  dvdd18-supply:
> > +    description:
> > +      1.8V power supply
> > +  avdd33-supply:
> > +    description:
> > +      3.3V power supply
> > +  i2c-supply:
> > +    description:
> > +      Power supply
> 
> Drop all useless descriptions (so : true)
> 
> > +  vconn-supply:
> > +    description:
> > +      Power supply
> > +  hdmi_vt-supply:
> > +    description:
> > +      Power supply
> > +
> > +  vbus-supply:
> > +    description:
> > +      Power supply
> > +  vbus_in-supply:
> 
> No underscores in property names.
> 
> > +    description:
> > +      Power supply
> > +
> > +  connector:
> > +    type: object
> > +    $ref: ../connector/usb-connector.yaml
> 
> Full path, so /schemas/connector/......
> 
> > +    unevaluatedProperties: false
> 
> Drop
> 
> > +
> > +    description:
> > +      Properties for usb c connector.
> 
> > +
> > +    properties:
> > +      compatible:
> > +        const: usb-c-connector
> > +
> > +      power-role: true
> > +
> > +      data-role: true
> > +
> > +      try-power-role: true
> 
> I don't understand why do you have here properties. Do you see any
> binding like this?
> 
> > +
> > +    required:
> > +      - compatible
> 
> Drop, why is it needed?
> 
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - connector
> > +
> > +additionalProperti
> 
> I don't know what's further but this patch is not a patch... Please read
> submitting-patches, organize your patchset correctly into manageable
> logical chunks and send them as proper patchset, not one junk.
> 
> b4 helps here a lot...
> 
> > 
> 
> Best regards,
> Krzysztof

-- 
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]