From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: phone-devel@vger.kernel.org,
kernel list <linux-kernel@vger.kernel.org>,
fiona.klute@gmx.de, martijn@brixit.nl, samuel@sholland.org,
heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
megi@xff.cz
Subject: Re: [PATCH] dt-bindings: usb: typec: anx7688: start a binding document
Date: Mon, 12 Feb 2024 12:16:36 +0100 [thread overview]
Message-ID: <db0d9666-796b-48e1-b830-2c9817a92b4f@linaro.org> (raw)
In-Reply-To: <Zcn6sSOqb+QpZtCC@duo.ucw.cz>
On 12/02/2024 12:02, Pavel Machek wrote:
> Hi!
>>> Add binding for anx7688 usb type-c bridge. I don't have a datasheet,
>>> but I did best I could.
>>>
>>> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>>>
>>
>> You miss proper diffstat which makes reviewing difficult.
>
>> Actually entire patch is corrupted and impossible to apply.
>
> Sorry about that.
>
>> Anyway, where is any user of this? Nothing in commit msg explains
>> this.
>
> User being is worked on:
>
> https://lore.kernel.org/lkml/2024020126-emote-unsubtly-3394@gregkh/T/
>
> Thanks for comments. I'll go through them and try to improve things.
OK, please send bindings patch in the same patchset as the driver.
Preferably first bindings patch, then driver patch(es). The bindings
document ABI exposed by driver, so we expect to see and apply both of
them together (apply through subsystem, so USB in this case).
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-12 11:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 19:51 Pavel Machek
2024-02-11 13:56 ` Krzysztof Kozlowski
2024-02-12 11:02 ` Pavel Machek
2024-02-12 11:16 ` Krzysztof Kozlowski [this message]
2024-02-21 22:45 ` Pavel Machek
2024-02-22 8:22 ` Krzysztof Kozlowski
2024-02-23 21:28 ` [PATCHv2 1/2] " Pavel Machek
2024-02-23 22:59 ` Rob Herring
2024-03-11 21:22 ` Pavel Machek
2024-03-12 10:51 ` Krzysztof Kozlowski
2024-02-23 21:28 ` [PATCHv2 2/2] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge Pavel Machek
2024-03-11 21:22 ` Pavel Machek
2024-03-12 14:12 ` Heikki Krogerus
2024-03-21 22:10 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db0d9666-796b-48e1-b830-2c9817a92b4f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fiona.klute@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martijn@brixit.nl \
--cc=megi@xff.cz \
--cc=pavel@ucw.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®