[PATCH V2] gpiolib: use dev_err() when gpiod_configure_flags failed

[PATCH V2] gpiolib: use dev_err() when gpiod_configure_flags failed

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

When gpio-ranges property was missed to be added in the gpio node,
using dev_err() to show an error message will helping to locate issues
easier.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---

V2:
 Update commit log

 drivers/gpio/gpiolib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index ce94e37bcbee..37fe9db0bd74 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -4233,7 +4233,7 @@ struct gpio_desc *gpiod_find_and_request(struct device *consumer,
 
 	ret = gpiod_configure_flags(desc, con_id, lookupflags, flags);
 	if (ret < 0) {
-		dev_dbg(consumer, "setup of GPIO %s failed\n", con_id);
+		dev_err(consumer, "setup of GPIO %s failed: %d\n", con_id, ret);
 		gpiod_put(desc);
 		return ERR_PTR(ret);
 	}
-- 
2.37.1

Re: [PATCH V2] gpiolib: use dev_err() when gpiod_configure_flags failed

[Andy Shevchenko]

On Wed, Mar 20, 2024 at 9:25 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> When gpio-ranges property was missed to be added in the gpio node,
> using dev_err() to show an error message will helping to locate issues
> easier.

I'm not convinced, so not my call to approve / reject, but see a remark below.

...

>         ret = gpiod_configure_flags(desc, con_id, lookupflags, flags);
>         if (ret < 0) {
> -               dev_dbg(consumer, "setup of GPIO %s failed\n", con_id);
> +               dev_err(consumer, "setup of GPIO %s failed: %d\n", con_id, ret);
>                 gpiod_put(desc);
>                 return ERR_PTR(ret);

While at it, can you move it to be after the gpiod_put()?

>         }

-- 
With Best Regards,
Andy Shevchenko

RE: [PATCH V2] gpiolib: use dev_err() when gpiod_configure_flags failed

[Peng Fan]

> Subject: Re: [PATCH V2] gpiolib: use dev_err() when gpiod_configure_flags
> failed
> 
> On Wed, Mar 20, 2024 at 9:25 AM Peng Fan (OSS) <peng.fan@oss.nxp.com>
> wrote:
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > When gpio-ranges property was missed to be added in the gpio node,
> > using dev_err() to show an error message will helping to locate issues
> > easier.
> 
> I'm not convinced, so not my call to approve / reject, but see a remark below.

You mean dev_err not help or else?

> 
> ...
> 
> >         ret = gpiod_configure_flags(desc, con_id, lookupflags, flags);
> >         if (ret < 0) {
> > -               dev_dbg(consumer, "setup of GPIO %s failed\n", con_id);
> > +               dev_err(consumer, "setup of GPIO %s failed: %d\n",
> > + con_id, ret);
> >                 gpiod_put(desc);
> >                 return ERR_PTR(ret);
> 
> While at it, can you move it to be after the gpiod_put()?

Does it matter?

Thanks,
Peng.

> 
> >         }
> 
> --
> With Best Regards,
> Andy Shevchenko

Re: [PATCH V2] gpiolib: use dev_err() when gpiod_configure_flags failed

[Andy Shevchenko]

On Wed, Mar 20, 2024 at 11:07:40AM +0000, Peng Fan wrote:
> > On Wed, Mar 20, 2024 at 9:25 AM Peng Fan (OSS) <peng.fan@oss.nxp.com>
> > wrote:

...

> > > When gpio-ranges property was missed to be added in the gpio node,
> > > using dev_err() to show an error message will helping to locate issues
> > > easier.
> > 
> > I'm not convinced, so not my call to approve / reject, but see a remark below.
> 
> You mean dev_err not help or else?

Moving it to error level.
Usually developers enable CONFIG_DEBUG_GPIO for these messages to appear.

...

> > >         ret = gpiod_configure_flags(desc, con_id, lookupflags, flags);
> > >         if (ret < 0) {
> > > -               dev_dbg(consumer, "setup of GPIO %s failed\n", con_id);
> > > +               dev_err(consumer, "setup of GPIO %s failed: %d\n",
> > > + con_id, ret);
> > >                 gpiod_put(desc);
> > >                 return ERR_PTR(ret);
> > 
> > While at it, can you move it to be after the gpiod_put()?
> 
> Does it matter?

Yes, the system gives resource back as soon as possible.

-- 
With Best Regards,
Andy Shevchenko

RE: [PATCH V2] gpiolib: use dev_err() when gpiod_configure_flags failed

[Peng Fan]

> Subject: Re: [PATCH V2] gpiolib: use dev_err() when gpiod_configure_flags
> failed
> 
> On Wed, Mar 20, 2024 at 11:07:40AM +0000, Peng Fan wrote:
> > > On Wed, Mar 20, 2024 at 9:25 AM Peng Fan (OSS)
> > > <peng.fan@oss.nxp.com>
> > > wrote:
> 
> ...
> 
> > > > When gpio-ranges property was missed to be added in the gpio node,
> > > > using dev_err() to show an error message will helping to locate
> > > > issues easier.
> > >
> > > I'm not convinced, so not my call to approve / reject, but see a remark
> below.
> >
> > You mean dev_err not help or else?
> 
> Moving it to error level.
> Usually developers enable CONFIG_DEBUG_GPIO for these messages to
> appear.

But this is a error log. Let's leave this to gpio maintainers.

> 
> ...
> 
> > > >         ret = gpiod_configure_flags(desc, con_id, lookupflags, flags);
> > > >         if (ret < 0) {
> > > > -               dev_dbg(consumer, "setup of GPIO %s failed\n", con_id);
> > > > +               dev_err(consumer, "setup of GPIO %s failed: %d\n",
> > > > + con_id, ret);
> > > >                 gpiod_put(desc);
> > > >                 return ERR_PTR(ret);
> > >
> > > While at it, can you move it to be after the gpiod_put()?
> >
> > Does it matter?
> 
> Yes, the system gives resource back as soon as possible.

Got it.

Thanks,
Peng.

> 
> --
> With Best Regards,
> Andy Shevchenko
> 

Re: [PATCH V2] gpiolib: use dev_err() when gpiod_configure_flags failed

[Bartosz Golaszewski]

On Thu, Mar 21, 2024 at 6:40 AM Peng Fan <peng.fan@nxp.com> wrote:
> > > >
> > > > I'm not convinced, so not my call to approve / reject, but see a remark
> > below.
> > >
> > > You mean dev_err not help or else?
> >
> > Moving it to error level.
> > Usually developers enable CONFIG_DEBUG_GPIO for these messages to
> > appear.
>
> But this is a error log. Let's leave this to gpio maintainers.
>

I'm fine with this change.

> >
> > ...
> >
> > > > >         ret = gpiod_configure_flags(desc, con_id, lookupflags, flags);
> > > > >         if (ret < 0) {
> > > > > -               dev_dbg(consumer, "setup of GPIO %s failed\n", con_id);
> > > > > +               dev_err(consumer, "setup of GPIO %s failed: %d\n",
> > > > > + con_id, ret);
> > > > >                 gpiod_put(desc);
> > > > >                 return ERR_PTR(ret);
> > > >
> > > > While at it, can you move it to be after the gpiod_put()?
> > >
> > > Does it matter?
> >
> > Yes, the system gives resource back as soon as possible.
>
> Got it.
>

Please change this and resend it.

Bart