* [PATCH] mm/page-flags: make PageMappingFlags return bool
@ 2024-03-07 13:13 Hao Ge
2024-03-21 3:07 ` [PATCH v2] " Hao Ge
0 siblings, 1 reply; 4+ messages in thread
From: Hao Ge @ 2024-03-07 13:13 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, gehao618, Hao Ge
make PageMappingFlags return bool like folio_mapping_flags
Signed-off-by: Hao Ge <gehao@kylinos.cn>
---
include/linux/page-flags.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
index 735cddc13d20..30740304059f 100644
--- a/include/linux/page-flags.h
+++ b/include/linux/page-flags.h
@@ -642,7 +642,7 @@ static __always_inline bool folio_mapping_flags(struct folio *folio)
return ((unsigned long)folio->mapping & PAGE_MAPPING_FLAGS) != 0;
}
-static __always_inline int PageMappingFlags(struct page *page)
+static __always_inline bool PageMappingFlags(struct page *page)
{
return ((unsigned long)page->mapping & PAGE_MAPPING_FLAGS) != 0;
}
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] mm/page-flags: make PageMappingFlags return bool
2024-03-07 13:13 [PATCH] mm/page-flags: make PageMappingFlags return bool Hao Ge
@ 2024-03-21 3:07 ` Hao Ge
2024-03-21 3:12 ` Matthew Wilcox
2024-04-04 19:26 ` David Hildenbrand
0 siblings, 2 replies; 4+ messages in thread
From: Hao Ge @ 2024-03-21 3:07 UTC (permalink / raw)
To: akpm; +Cc: willy, gehao618, linux-kernel, linux-mm, Hao Ge
make PageMappingFlags return bool like folio_mapping_flags
Signed-off-by: Hao Ge <gehao@kylinos.cn>
---
v2: Send this patch on the latest version
---
include/linux/page-flags.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
index 652d77805e99..5ee2d0ab62c6 100644
--- a/include/linux/page-flags.h
+++ b/include/linux/page-flags.h
@@ -668,7 +668,7 @@ static __always_inline bool folio_mapping_flags(const struct folio *folio)
return ((unsigned long)folio->mapping & PAGE_MAPPING_FLAGS) != 0;
}
-static __always_inline int PageMappingFlags(const struct page *page)
+static __always_inline bool PageMappingFlags(const struct page *page)
{
return ((unsigned long)page->mapping & PAGE_MAPPING_FLAGS) != 0;
}
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] mm/page-flags: make PageMappingFlags return bool
2024-03-21 3:07 ` [PATCH v2] " Hao Ge
@ 2024-03-21 3:12 ` Matthew Wilcox
2024-04-04 19:26 ` David Hildenbrand
1 sibling, 0 replies; 4+ messages in thread
From: Matthew Wilcox @ 2024-03-21 3:12 UTC (permalink / raw)
To: Hao Ge; +Cc: akpm, gehao618, linux-kernel, linux-mm
On Thu, Mar 21, 2024 at 11:07:12AM +0800, Hao Ge wrote:
> make PageMappingFlags return bool like folio_mapping_flags
>
> Signed-off-by: Hao Ge <gehao@kylinos.cn>
>
> ---
> v2: Send this patch on the latest version
I don't see v1 in my inbox. Regardless, this is clearly the right
thing.
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] mm/page-flags: make PageMappingFlags return bool
2024-03-21 3:07 ` [PATCH v2] " Hao Ge
2024-03-21 3:12 ` Matthew Wilcox
@ 2024-04-04 19:26 ` David Hildenbrand
1 sibling, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2024-04-04 19:26 UTC (permalink / raw)
To: Hao Ge, akpm; +Cc: willy, gehao618, linux-kernel, linux-mm
On 21.03.24 04:07, Hao Ge wrote:
> make PageMappingFlags return bool like folio_mapping_flags
>
> Signed-off-by: Hao Ge <gehao@kylinos.cn>
>
> ---
> v2: Send this patch on the latest version
> ---
> include/linux/page-flags.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
> index 652d77805e99..5ee2d0ab62c6 100644
> --- a/include/linux/page-flags.h
> +++ b/include/linux/page-flags.h
> @@ -668,7 +668,7 @@ static __always_inline bool folio_mapping_flags(const struct folio *folio)
> return ((unsigned long)folio->mapping & PAGE_MAPPING_FLAGS) != 0;
> }
>
> -static __always_inline int PageMappingFlags(const struct page *page)
> +static __always_inline bool PageMappingFlags(const struct page *page)
> {
> return ((unsigned long)page->mapping & PAGE_MAPPING_FLAGS) != 0;
> }
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-04 19:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-07 13:13 [PATCH] mm/page-flags: make PageMappingFlags return bool Hao Ge
2024-03-21 3:07 ` [PATCH v2] " Hao Ge
2024-03-21 3:12 ` Matthew Wilcox
2024-04-04 19:26 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®