From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: kernel test robot <oliver.sang@intel.com>
Cc: Yicong Yang <yangyicong@hisilicon.com>,
oe-lkp@lists.linux.dev, lkp@intel.com,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable <stable@kernel.org>, Tony Lindgren <tony@atomide.com>,
linux-serial@vger.kernel.org
Subject: Re: [linus:master] [serial] 43066e3222: BUG:kernel_NULL_pointer_dereference,address
Date: Wed, 3 Apr 2024 17:00:38 +0300 [thread overview]
Message-ID: <Zg1hBvRAxifo50sf@smile.fi.intel.com> (raw)
In-Reply-To: <202404031607.2e92eebe-lkp@intel.com>
On Wed, Apr 03, 2024 at 09:43:28PM +0800, kernel test robot wrote:
> kernel test robot noticed "BUG:kernel_NULL_pointer_dereference,address" on:
>
> commit: 43066e32227ecde674e8ae1fcdd4a1ede67680c2 ("serial: port: Don't suspend if the port is still busy")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
Ja-ja, I am investigating this issue for a while (not that I spend all my time
on it, though) on max3100.
The problem seems that we enable PM runtime on all serial ports
(even if they have no RPM support), but at the same time we enforce
the common serial_port PM callbacks and that change misses a detail
on how to check the port status as the real callback may happen
quite after the port being closed (/dev/ttySx).
Probably we need to check if the port is still open...
P.S. AFAIU the state / xmit is invalid pointer or so.
Culprit line: serial_out(up, UART_TX, xmit->buf[xmit->tail]);
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-04-03 14:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 13:43 kernel test robot
2024-04-03 14:00 ` Andy Shevchenko [this message]
2024-04-04 6:54 ` Tony Lindgren
2024-04-04 11:59 ` Andy Shevchenko
2024-04-04 14:42 ` Andy Shevchenko
2024-04-04 14:34 ` Andy Shevchenko
2024-04-05 5:46 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zg1hBvRAxifo50sf@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=stable@kernel.org \
--cc=tony@atomide.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®