From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tony Lindgren <tony@atomide.com>
Cc: kernel test robot <oliver.sang@intel.com>,
Yicong Yang <yangyicong@hisilicon.com>,
oe-lkp@lists.linux.dev, lkp@intel.com,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable <stable@kernel.org>,
linux-serial@vger.kernel.org
Subject: Re: [linus:master] [serial] 43066e3222: BUG:kernel_NULL_pointer_dereference,address
Date: Thu, 4 Apr 2024 17:42:29 +0300 [thread overview]
Message-ID: <Zg68VV8LW1A8g5BZ@smile.fi.intel.com> (raw)
In-Reply-To: <Zg6WF0DMePE-V1V0@smile.fi.intel.com>
On Thu, Apr 04, 2024 at 02:59:19PM +0300, Andy Shevchenko wrote:
> On Thu, Apr 04, 2024 at 09:54:15AM +0300, Tony Lindgren wrote:
> > * Andy Shevchenko <andriy.shevchenko@linux.intel.com> [240403 14:00]:
> > > Probably we need to check if the port is still open...
> > >
> > > P.S. AFAIU the state / xmit is invalid pointer or so.
> > >
> > > Culprit line: serial_out(up, UART_TX, xmit->buf[xmit->tail]);
>
> xmit.buf seems to be NULL, that's why this fails.
>
> > Maybe we can set UPF_DEAD a bit earlier as below?
>
> Lemme perform some tests later today.
Okay, so far it doesn't fix the issue AFAICT. The only reliable one right now
to me is clearing circ buffer before NULLifying it.
I'll send a formal patch.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-04-04 14:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 13:43 kernel test robot
2024-04-03 14:00 ` Andy Shevchenko
2024-04-04 6:54 ` Tony Lindgren
2024-04-04 11:59 ` Andy Shevchenko
2024-04-04 14:42 ` Andy Shevchenko [this message]
2024-04-04 14:34 ` Andy Shevchenko
2024-04-05 5:46 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zg68VV8LW1A8g5BZ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=stable@kernel.org \
--cc=tony@atomide.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®