* [PATCH] mtd: partitions: redboot: Added conversion of operands to a larger type
@ 2024-03-15 9:37 Denis Arefev
2024-03-25 10:18 ` Miquel Raynal
2024-03-25 10:30 ` Andy Shevchenko
0 siblings, 2 replies; 4+ messages in thread
From: Denis Arefev @ 2024-03-15 9:37 UTC (permalink / raw)
To: Miquel Raynal
Cc: Richard Weinberger, Vignesh Raghavendra, linux-mtd, linux-kernel,
lvc-project, trufanov, vfh
The value of an arithmetic expression directory * master->erasesize is
subject to overflow due to a failure to cast operands to a larger data
type before perfroming arithmetic
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Denis Arefev <arefev@swemel.ru>
---
drivers/mtd/parsers/redboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/parsers/redboot.c b/drivers/mtd/parsers/redboot.c
index a16b42a88581..3b55b676ca6b 100644
--- a/drivers/mtd/parsers/redboot.c
+++ b/drivers/mtd/parsers/redboot.c
@@ -102,7 +102,7 @@ static int parse_redboot_partitions(struct mtd_info *master,
offset -= master->erasesize;
}
} else {
- offset = directory * master->erasesize;
+ offset = (unsigned long) directory * master->erasesize;
while (mtd_block_isbad(master, offset)) {
offset += master->erasesize;
if (offset == master->size)
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mtd: partitions: redboot: Added conversion of operands to a larger type
2024-03-15 9:37 [PATCH] mtd: partitions: redboot: Added conversion of operands to a larger type Denis Arefev
@ 2024-03-25 10:18 ` Miquel Raynal
2024-03-25 10:30 ` Andy Shevchenko
1 sibling, 0 replies; 4+ messages in thread
From: Miquel Raynal @ 2024-03-25 10:18 UTC (permalink / raw)
To: Denis Arefev, Miquel Raynal
Cc: Richard Weinberger, Vignesh Raghavendra, linux-mtd, linux-kernel,
lvc-project, trufanov, vfh
On Fri, 2024-03-15 at 09:37:58 UTC, Denis Arefev wrote:
> The value of an arithmetic expression directory * master->erasesize is
> subject to overflow due to a failure to cast operands to a larger data
> type before perfroming arithmetic
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Denis Arefev <arefev@swemel.ru>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: partitions: redboot: Added conversion of operands to a larger type
2024-03-15 9:37 [PATCH] mtd: partitions: redboot: Added conversion of operands to a larger type Denis Arefev
2024-03-25 10:18 ` Miquel Raynal
@ 2024-03-25 10:30 ` Andy Shevchenko
1 sibling, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2024-03-25 10:30 UTC (permalink / raw)
To: Denis Arefev
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
linux-mtd, linux-kernel, lvc-project, trufanov, vfh
On Fri, Mar 15, 2024 at 12:37:58PM +0300, Denis Arefev wrote:
> The value of an arithmetic expression directory * master->erasesize is
> subject to overflow due to a failure to cast operands to a larger data
> type before perfroming arithmetic
...
> - offset = directory * master->erasesize;
> + offset = (unsigned long) directory * master->erasesize;
Usage of explicit casting can be avoided by using size_mul() from overflow.h.
Usually explicit castings are prone to subtle errors.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] mtd: partitions: redboot: Added conversion of operands to a larger type
@ 2024-09-10 10:11 Denis Arefev
0 siblings, 0 replies; 4+ messages in thread
From: Denis Arefev @ 2024-09-10 10:11 UTC (permalink / raw)
To: Miquel Raynal
Cc: Richard Weinberger, Vignesh Raghavendra, linux-mtd, linux-kernel,
lvc-project
The value of an arithmetic expression directory * master->erasesize is
subject to overflow due to a failure to cast operands to a larger data
type before perfroming arithmetic
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Denis Arefev <arefev@swemel.ru>
---
drivers/mtd/parsers/redboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/parsers/redboot.c b/drivers/mtd/parsers/redboot.c
index 3b55b676ca6b..c8f7e7b351d7 100644
--- a/drivers/mtd/parsers/redboot.c
+++ b/drivers/mtd/parsers/redboot.c
@@ -92,7 +92,7 @@ static int parse_redboot_partitions(struct mtd_info *master,
parse_redboot_of(master);
if (directory < 0) {
- offset = master->size + directory * master->erasesize;
+ offset = master->size + (unsigned long) directory * master->erasesize;
while (mtd_block_isbad(master, offset)) {
if (!offset) {
nogood:
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-09-10 10:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-15 9:37 [PATCH] mtd: partitions: redboot: Added conversion of operands to a larger type Denis Arefev
2024-03-25 10:18 ` Miquel Raynal
2024-03-25 10:30 ` Andy Shevchenko
2024-09-10 10:11 Denis Arefev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®