* [PATCH] usb: typec: mux: it5205: Fix ChipID value typo
@ 2024-04-09 11:36 AngeloGioacchino Del Regno
2024-04-15 6:53 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-04-09 11:36 UTC (permalink / raw)
To: heikki.krogerus
Cc: gregkh, angelogioacchino.delregno, dmitry.baryshkov, linux-usb,
linux-kernel, kernel
The ChipID bytes are read in inverse order: invert the ChipID value
defined as IT5205FN_CHIP_ID and used for validating the same.
Fixes: 41fe9ea1696c ("usb: typec: mux: Add ITE IT5205 Alternate Mode Passive MUX driver")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/usb/typec/mux/it5205.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/typec/mux/it5205.c b/drivers/usb/typec/mux/it5205.c
index 5535932e42cd..4357cc67a867 100644
--- a/drivers/usb/typec/mux/it5205.c
+++ b/drivers/usb/typec/mux/it5205.c
@@ -22,7 +22,7 @@
#include <linux/usb/typec_mux.h>
#define IT5205_REG_CHIP_ID(x) (0x4 + (x))
-#define IT5205FN_CHIP_ID 0x35323035 /* "5205" */
+#define IT5205FN_CHIP_ID 0x35303235 /* "5025" -> "5205" */
/* MUX power down register */
#define IT5205_REG_MUXPDR 0x10
--
2.44.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] usb: typec: mux: it5205: Fix ChipID value typo
2024-04-09 11:36 [PATCH] usb: typec: mux: it5205: Fix ChipID value typo AngeloGioacchino Del Regno
@ 2024-04-15 6:53 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2024-04-15 6:53 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: gregkh, dmitry.baryshkov, linux-usb, linux-kernel, kernel
On Tue, Apr 09, 2024 at 01:36:46PM +0200, AngeloGioacchino Del Regno wrote:
> The ChipID bytes are read in inverse order: invert the ChipID value
> defined as IT5205FN_CHIP_ID and used for validating the same.
>
> Fixes: 41fe9ea1696c ("usb: typec: mux: Add ITE IT5205 Alternate Mode Passive MUX driver")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/mux/it5205.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/mux/it5205.c b/drivers/usb/typec/mux/it5205.c
> index 5535932e42cd..4357cc67a867 100644
> --- a/drivers/usb/typec/mux/it5205.c
> +++ b/drivers/usb/typec/mux/it5205.c
> @@ -22,7 +22,7 @@
> #include <linux/usb/typec_mux.h>
>
> #define IT5205_REG_CHIP_ID(x) (0x4 + (x))
> -#define IT5205FN_CHIP_ID 0x35323035 /* "5205" */
> +#define IT5205FN_CHIP_ID 0x35303235 /* "5025" -> "5205" */
>
> /* MUX power down register */
> #define IT5205_REG_MUXPDR 0x10
> --
> 2.44.0
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-15 6:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-09 11:36 [PATCH] usb: typec: mux: it5205: Fix ChipID value typo AngeloGioacchino Del Regno
2024-04-15 6:53 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®