* [PATCH -next] cgroup_freezer: update comment for freezer_css_online()
@ 2024-04-17 3:50 Xiu Jianfeng
2024-04-18 2:00 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Xiu Jianfeng @ 2024-04-17 3:50 UTC (permalink / raw)
To: tj, lizefan.x, hannes; +Cc: cgroups, linux-kernel
From: Xiu Jianfeng <xiujianfeng@huawei.com>
The freezer->lock was replaced by freezer_mutex in commit e5ced8ebb10c
("cgroup_freezer: replace freezer->lock with freezer_mutex"), so the
comment here is out-of-date, update it.
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
---
kernel/cgroup/legacy_freezer.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/cgroup/legacy_freezer.c b/kernel/cgroup/legacy_freezer.c
index 66d1708042a7..d598cc6ee92e 100644
--- a/kernel/cgroup/legacy_freezer.c
+++ b/kernel/cgroup/legacy_freezer.c
@@ -106,8 +106,7 @@ freezer_css_alloc(struct cgroup_subsys_state *parent_css)
* @css: css being created
*
* We're committing to creation of @css. Mark it online and inherit
- * parent's freezing state while holding both parent's and our
- * freezer->lock.
+ * parent's freezing state while holding cpus read lock and freezer_mutex.
*/
static int freezer_css_online(struct cgroup_subsys_state *css)
{
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] cgroup_freezer: update comment for freezer_css_online()
2024-04-17 3:50 [PATCH -next] cgroup_freezer: update comment for freezer_css_online() Xiu Jianfeng
@ 2024-04-18 2:00 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2024-04-18 2:00 UTC (permalink / raw)
To: Xiu Jianfeng; +Cc: lizefan.x, hannes, cgroups, linux-kernel
On Wed, Apr 17, 2024 at 03:50:28AM +0000, Xiu Jianfeng wrote:
> From: Xiu Jianfeng <xiujianfeng@huawei.com>
>
> The freezer->lock was replaced by freezer_mutex in commit e5ced8ebb10c
> ("cgroup_freezer: replace freezer->lock with freezer_mutex"), so the
> comment here is out-of-date, update it.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Applied to cgroup/for-6.10.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-18 2:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-17 3:50 [PATCH -next] cgroup_freezer: update comment for freezer_css_online() Xiu Jianfeng
2024-04-18 2:00 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®