* [PATCH -next] cgroup: don't call cgroup1_pidlist_destroy_all() for v2
@ 2024-04-17 2:13 Xiu Jianfeng
2024-04-18 2:02 ` Tejun Heo
0 siblings, 1 reply; 3+ messages in thread
From: Xiu Jianfeng @ 2024-04-17 2:13 UTC (permalink / raw)
To: tj, lizefan.x, hannes; +Cc: cgroups, linux-kernel
From: Xiu Jianfeng <xiujianfeng@huawei.com>
Currently cgroup1_pidlist_destroy_all() will be called when releasing
cgroup even if the cgroup is on default hierarchy, however it doesn't
make any sense for v2 to destroy pidlist of v1.
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
---
kernel/cgroup/cgroup-v1.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/cgroup/cgroup-v1.c b/kernel/cgroup/cgroup-v1.c
index 520a11cb12f4..46d89157d558 100644
--- a/kernel/cgroup/cgroup-v1.c
+++ b/kernel/cgroup/cgroup-v1.c
@@ -197,6 +197,8 @@ void cgroup1_pidlist_destroy_all(struct cgroup *cgrp)
{
struct cgroup_pidlist *l, *tmp_l;
+ if (cgroup_on_dfl(cgrp))
+ return;
mutex_lock(&cgrp->pidlist_mutex);
list_for_each_entry_safe(l, tmp_l, &cgrp->pidlists, links)
mod_delayed_work(cgroup_pidlist_destroy_wq, &l->destroy_dwork, 0);
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] cgroup: don't call cgroup1_pidlist_destroy_all() for v2
2024-04-17 2:13 [PATCH -next] cgroup: don't call cgroup1_pidlist_destroy_all() for v2 Xiu Jianfeng
@ 2024-04-18 2:02 ` Tejun Heo
2024-04-18 2:11 ` xiujianfeng
0 siblings, 1 reply; 3+ messages in thread
From: Tejun Heo @ 2024-04-18 2:02 UTC (permalink / raw)
To: Xiu Jianfeng; +Cc: lizefan.x, hannes, cgroups, linux-kernel
Hello,
On Wed, Apr 17, 2024 at 02:13:59AM +0000, Xiu Jianfeng wrote:
> From: Xiu Jianfeng <xiujianfeng@huawei.com>
>
> Currently cgroup1_pidlist_destroy_all() will be called when releasing
> cgroup even if the cgroup is on default hierarchy, however it doesn't
> make any sense for v2 to destroy pidlist of v1.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> ---
> kernel/cgroup/cgroup-v1.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/cgroup/cgroup-v1.c b/kernel/cgroup/cgroup-v1.c
> index 520a11cb12f4..46d89157d558 100644
> --- a/kernel/cgroup/cgroup-v1.c
> +++ b/kernel/cgroup/cgroup-v1.c
> @@ -197,6 +197,8 @@ void cgroup1_pidlist_destroy_all(struct cgroup *cgrp)
> {
> struct cgroup_pidlist *l, *tmp_l;
>
> + if (cgroup_on_dfl(cgrp))
> + return;
Can you move the test to the caller?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] cgroup: don't call cgroup1_pidlist_destroy_all() for v2
2024-04-18 2:02 ` Tejun Heo
@ 2024-04-18 2:11 ` xiujianfeng
0 siblings, 0 replies; 3+ messages in thread
From: xiujianfeng @ 2024-04-18 2:11 UTC (permalink / raw)
To: Tejun Heo, Xiu Jianfeng; +Cc: lizefan.x, hannes, cgroups, linux-kernel
Hi,
On 2024/4/18 10:02, Tejun Heo wrote:
> Hello,
>
> On Wed, Apr 17, 2024 at 02:13:59AM +0000, Xiu Jianfeng wrote:
>> From: Xiu Jianfeng <xiujianfeng@huawei.com>
>>
>> Currently cgroup1_pidlist_destroy_all() will be called when releasing
>> cgroup even if the cgroup is on default hierarchy, however it doesn't
>> make any sense for v2 to destroy pidlist of v1.
>>
>> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
>> ---
>> kernel/cgroup/cgroup-v1.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/kernel/cgroup/cgroup-v1.c b/kernel/cgroup/cgroup-v1.c
>> index 520a11cb12f4..46d89157d558 100644
>> --- a/kernel/cgroup/cgroup-v1.c
>> +++ b/kernel/cgroup/cgroup-v1.c
>> @@ -197,6 +197,8 @@ void cgroup1_pidlist_destroy_all(struct cgroup *cgrp)
>> {
>> struct cgroup_pidlist *l, *tmp_l;
>>
>> + if (cgroup_on_dfl(cgrp))
>> + return;
>
> Can you move the test to the caller?
Sure, will do in v2.
>
> Thanks.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-18 2:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-17 2:13 [PATCH -next] cgroup: don't call cgroup1_pidlist_destroy_all() for v2 Xiu Jianfeng
2024-04-18 2:02 ` Tejun Heo
2024-04-18 2:11 ` xiujianfeng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®