From: Mark Brown <broonie@kernel.org>
To: Witold Sadowski <wsadowski@marvell.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"pthombar@cadence.com" <pthombar@cadence.com>
Subject: Re: [EXTERNAL] Re: [PATCH v8 4/4] spi: cadence: Add MRVL overlay xfer operation support
Date: Wed, 12 Jun 2024 11:37:56 +0100 [thread overview]
Message-ID: <Zml6hP4dFZCLKW6T@finisterre.sirena.org.uk> (raw)
In-Reply-To: <CO6PR18MB40985A453930C40DCB5C5845B0C72@CO6PR18MB4098.namprd18.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 428 bytes --]
On Tue, Jun 11, 2024 at 10:02:33PM +0000, Witold Sadowski wrote:
> > > + cdns_xspi->in_buffer = txd + 1;
> > > + cdns_xspi->out_buffer = txd + 1;
> > Oh?
> You are asking about that 1 byte offset? It is caused by way that
> SDMA is handled in that specific case - all data except of first
> byte is transferred via SDMA, the first byte is send in command, and
> SDMA is not involved in that.
That needs a comment I think.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-06-12 10:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 15:18 [PATCH v8 0/4] Marvell HW overlay support for Cadence xSPI Witold Sadowski
2024-06-07 15:18 ` [PATCH v8 1/4] spi: dt-bindings: cadence: Add Marvell overlay bindings documentation for Cadence XSPI Witold Sadowski
2024-06-07 15:18 ` [PATCH v8 2/4] spi: cadence: Add Marvell xSPI IP overlay changes Witold Sadowski
2024-06-10 16:03 ` Mark Brown
2024-06-11 21:51 ` [EXTERNAL] " Witold Sadowski
2024-06-12 10:31 ` Mark Brown
2024-06-07 15:18 ` [PATCH v8 3/4] spi: cadence: Allow to read basic xSPI configuration from ACPI Witold Sadowski
2024-06-10 16:08 ` Mark Brown
2024-06-11 21:57 ` [EXTERNAL] " Witold Sadowski
2024-06-12 10:35 ` Mark Brown
2024-06-07 15:18 ` [PATCH v8 4/4] spi: cadence: Add MRVL overlay xfer operation support Witold Sadowski
2024-06-10 16:19 ` Mark Brown
2024-06-11 22:02 ` [EXTERNAL] " Witold Sadowski
2024-06-12 10:37 ` Mark Brown [this message]
2024-06-18 12:59 ` Witold Sadowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zml6hP4dFZCLKW6T@finisterre.sirena.org.uk \
--to=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=pthombar@cadence.com \
--cc=robh@kernel.org \
--cc=wsadowski@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®