[PATCH] vsprintf: add missing MODULE_DESCRIPTION() macro

[PATCH] vsprintf: add missing MODULE_DESCRIPTION() macro

[Jeff Johnson]

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_printf.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_scanf.o

Add the missing invocations of the MODULE_DESCRIPTION() macro.

(Using vsprintf prefix since these files match the VSPRINTF entry in
the MAINTAINERS file)

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 lib/test_printf.c | 1 +
 lib/test_scanf.c  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/lib/test_printf.c b/lib/test_printf.c
index 69b6a5e177f2..965cb6f28527 100644
--- a/lib/test_printf.c
+++ b/lib/test_printf.c
@@ -824,4 +824,5 @@ static void __init selftest(void)
 
 KSTM_MODULE_LOADERS(test_printf);
 MODULE_AUTHOR("Rasmus Villemoes <linux@rasmusvillemoes.dk>");
+MODULE_DESCRIPTION("Test cases for printf facility");
 MODULE_LICENSE("GPL");
diff --git a/lib/test_scanf.c b/lib/test_scanf.c
index a2707af2951a..7257b1768545 100644
--- a/lib/test_scanf.c
+++ b/lib/test_scanf.c
@@ -810,4 +810,5 @@ static void __init selftest(void)
 
 KSTM_MODULE_LOADERS(test_scanf);
 MODULE_AUTHOR("Richard Fitzgerald <rf@opensource.cirrus.com>");
+MODULE_DESCRIPTION("Test cases for sscanf facility");
 MODULE_LICENSE("GPL v2");

---
base-commit: b050496579632f86ee1ef7e7501906db579f3457
change-id: 20240531-md-vsprintf-dab845ebc566

Re: [PATCH] vsprintf: add missing MODULE_DESCRIPTION() macro

[Petr Mladek]

On Fri 2024-05-31 19:42:25, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_printf.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_scanf.o
> 
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr

Re: [PATCH] vsprintf: add missing MODULE_DESCRIPTION() macro

[Petr Mladek]

On Fri 2024-05-31 19:42:25, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_printf.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_scanf.o
> 
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

JFYI, the patch has been comitted into printk/linux.git,
branch for-6.11.

Best Regards,
Petr

Re: [PATCH] vsprintf: add missing MODULE_DESCRIPTION() macro

[Jeff Johnson]

On 6/12/2024 4:31 AM, Petr Mladek wrote:
> On Fri 2024-05-31 19:42:25, Jeff Johnson wrote:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_printf.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_scanf.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> 
> JFYI, the patch has been comitted into printk/linux.git,
> branch for-6.11.
> 
> Best Regards,
> Petr

Hi Petr,
I see this landed in linux-next, but is not currently in Linus' tree for 6.11.
Will you be able to have this pulled during the merge window?
I'm trying to eradicate all of these warnings before 6.11 rc-final.

Thanks!
/jeff

Re: [PATCH] vsprintf: add missing MODULE_DESCRIPTION() macro

[Petr Mladek]

On Tue 2024-07-23 11:53:34, Jeff Johnson wrote:
> On 6/12/2024 4:31 AM, Petr Mladek wrote:
> > On Fri 2024-05-31 19:42:25, Jeff Johnson wrote:
> >> make allmodconfig && make W=1 C=1 reports:
> >> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_printf.o
> >> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_scanf.o
> >>
> >> Add the missing invocations of the MODULE_DESCRIPTION() macro.
> >>
> >> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> > 
> > JFYI, the patch has been comitted into printk/linux.git,
> > branch for-6.11.
> > 
> > Best Regards,
> > Petr
> 
> Hi Petr,
> I see this landed in linux-next, but is not currently in Linus' tree for 6.11.
> Will you be able to have this pulled during the merge window?
> I'm trying to eradicate all of these warnings before 6.11 rc-final.

The pull request is still being discussed, see
https://lore.kernel.org/r/CAHk-=whU_woFnFN-3Jv2hNCmwLg_fkrT42AWwxm-=Ha5BmNX4w@mail.gmail.com

If the printk rework part is not acceptable then I'll send these
trivial changes separately.

Best Regards,
Petr

PS: I have sent the pull request late because I have had vacation
    previous two weeks.

Re: [PATCH] vsprintf: add missing MODULE_DESCRIPTION() macro

[Jeff Johnson]

On 7/24/2024 7:02 AM, Petr Mladek wrote:
> On Tue 2024-07-23 11:53:34, Jeff Johnson wrote:
>> On 6/12/2024 4:31 AM, Petr Mladek wrote:
>>> On Fri 2024-05-31 19:42:25, Jeff Johnson wrote:
>>>> make allmodconfig && make W=1 C=1 reports:
>>>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_printf.o
>>>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_scanf.o
>>>>
>>>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>>>
>>>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>>>
>>> JFYI, the patch has been comitted into printk/linux.git,
>>> branch for-6.11.
>>>
>>> Best Regards,
>>> Petr
>>
>> Hi Petr,
>> I see this landed in linux-next, but is not currently in Linus' tree for 6.11.
>> Will you be able to have this pulled during the merge window?
>> I'm trying to eradicate all of these warnings before 6.11 rc-final.
> 
> The pull request is still being discussed, see
> https://lore.kernel.org/r/CAHk-=whU_woFnFN-3Jv2hNCmwLg_fkrT42AWwxm-=Ha5BmNX4w@mail.gmail.com
> 
> If the printk rework part is not acceptable then I'll send these
> trivial changes separately.
> 
> Best Regards,
> Petr
> 
> PS: I have sent the pull request late because I have had vacation
>     previous two weeks.

Thanks for the update.

Note that, at the advice of Greg KH, after the merge window closes I'll send a
series that contains all of the MODULE_DESCRIPTION patches that didn't make it
in, so it can come in via that series as well.

/jeff