From: Tejun Heo <tj@kernel.org>
To: Xavier <xavier_qy@163.com>
Cc: longman@redhat.com, mkoutny@suse.com, lizefan.x@bytedance.com,
hannes@cmpxchg.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org
Subject: Re: [PATCH-cpuset v7 0/2] Add Union-Find and use it to optimize cpuset
Date: Thu, 27 Jun 2024 11:06:48 -1000 [thread overview]
Message-ID: <Zn3UaMouBYYIMQr_@slm.duckdns.org> (raw)
In-Reply-To: <20240623023901.218892-1-xavier_qy@163.com>
Hello, Xavier.
On Sun, Jun 23, 2024 at 10:38:59AM +0800, Xavier wrote:
> I think I understand your point now. I have modified the Union-Find
> implementation so that the allocation and deallocation are handled by the
> user, providing only the initialization interface. Thanks for your
> suggestion.
I recommend spending more time studying the existing data structures. The
pattern is pretty universal. The element is often embedded in a containing
structure. Macros and init methods are provided to initialize the element
along with operations which implement the data structure operations, and
then we use container_of() to obtain the embedding structure. We very rarely
allocate data structure members by themselves.
Also, the cleanup in cpuset seems nice but, if you can think of other use
cases, that'd be great too.
Thanks.
--
tejun
next prev parent reply other threads:[~2024-06-27 21:06 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 2:48 [PATCH v2] cpuset: Optimize the number of iterations in the scheduling domain construction process Xavier
2024-05-31 21:13 ` Waiman Long
2024-06-03 12:31 ` [PATCH v3] cpuset: use Union-Find to optimize the merging of cpumasks Xavier
2024-06-04 15:02 ` Waiman Long
2024-06-10 17:18 ` Michal Koutný
2024-06-20 8:52 ` [PATCH v4 v4 0/2] cpuset: use Union-Find to optimize Xavier
2024-06-20 8:52 ` [PATCH v4 v4 1/2] Union-Find: add a new module in kernel library Xavier
2024-06-20 14:54 ` Waiman Long
2024-06-21 8:49 ` [PATCH-cpuset v5 0/2] cpuset: use Union-Find to optimize Xavier
2024-06-21 8:49 ` [PATCH-cpuset v5 1/2] Union-Find: add a new module in kernel library Xavier
2024-06-21 21:10 ` Tejun Heo
2024-06-22 7:14 ` [PATCH-cpuset v6 0/2] Add Union-Find and use it to optimize cpuset Xavier
2024-06-22 7:14 ` [PATCH-cpuset v6 1/2] Union-Find: add a new module in kernel library Xavier
2024-06-22 7:14 ` [PATCH-cpuset v6 2/2] cpuset: use Union-Find to optimize the merging of cpumasks Xavier
2024-06-22 16:13 ` [PATCH-cpuset v6 0/2] Add Union-Find and use it to optimize cpuset Tejun Heo
2024-06-23 2:38 ` [PATCH-cpuset v7 " Xavier
2024-06-23 2:39 ` [PATCH-cpuset v7 1/2] Union-Find: add a new module in kernel library Xavier
2024-06-23 2:39 ` [PATCH-cpuset v7 2/2] cpuset: use Union-Find to optimize the merging of cpumasks Xavier
2024-06-27 21:06 ` Tejun Heo [this message]
2024-06-28 16:13 ` [PATCH-cpuset v8 0/2] Add Union-Find and use it to optimize cpuset Xavier
2024-06-28 16:13 ` [PATCH-cpuset v8 1/2] Union-Find: add a new module in kernel library Xavier
2024-07-01 20:53 ` Tejun Heo
2024-07-02 10:50 ` [PATCH-cpuset v9 0/2] Add Union-Find and use it to optimize cpuset Xavier
2024-07-02 10:50 ` [PATCH-cpuset v9 1/2] Union-Find: add a new module in kernel library Xavier
2024-07-02 10:50 ` [PATCH-cpuset v9 2/2] cpuset: use Union-Find to optimize the merging of cpumasks Xavier
2024-07-03 3:05 ` Waiman Long
2024-07-02 19:22 ` [PATCH-cpuset v9 0/2] Add Union-Find and use it to optimize cpuset Tejun Heo
2024-07-03 0:31 ` Andrew Morton
2024-07-03 17:34 ` Tejun Heo
2024-07-03 6:37 ` [PATCH-cpuset v10 " Xavier
2024-07-03 6:37 ` [PATCH-cpuset v10 1/2] Union-Find: add a new module in kernel library Xavier
2024-07-03 9:40 ` Michal Koutný
2024-07-03 11:20 ` Xavier
2024-07-04 12:12 ` Michal Koutný
2024-07-03 6:37 ` [PATCH-cpuset v10 2/2] cpuset: use Union-Find to optimize the merging of cpumasks Xavier
2024-07-03 9:40 ` Michal Koutný
2024-07-03 10:49 ` Xavier
2024-07-03 16:43 ` Waiman Long
2024-07-04 6:24 ` [PATCH-cpuset v11 0/2] Add Union-Find and use it to optimize cpuset Xavier
2024-07-04 6:24 ` [PATCH-cpuset v11 1/2] Union-Find: add a new module in kernel library Xavier
2024-07-30 23:05 ` Tejun Heo
2024-07-04 6:24 ` [PATCH-cpuset v11 2/2] cpuset: use Union-Find to optimize the merging of cpumasks Xavier
2024-07-30 23:05 ` Tejun Heo
2024-07-08 1:59 ` [PATCH-cpuset v11 0/2] Add Union-Find and use it to optimize cpuset Waiman Long
2024-07-08 18:38 ` Tejun Heo
2024-07-09 2:45 ` Xavier
2024-07-29 2:44 ` Xavier
2024-07-30 23:06 ` Tejun Heo
2024-06-28 16:13 ` [PATCH-cpuset v8 2/2] cpuset: use Union-Find to optimize the merging of cpumasks Xavier
2024-07-01 20:53 ` Tejun Heo
2024-06-21 8:49 ` [PATCH-cpuset v5 " Xavier
2024-06-20 8:52 ` [PATCH v4 v4 " Xavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zn3UaMouBYYIMQr_@slm.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=mkoutny@suse.com \
--cc=torvalds@linux-foundation.org \
--cc=xavier_qy@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®