* [PATCH net v2 1/1] net: phy: microchip: lan87xx: reinit PHY after cable test
@ 2024-07-04 5:31 Oleksij Rempel
2024-07-04 5:45 ` Oleksij Rempel
0 siblings, 1 reply; 2+ messages in thread
From: Oleksij Rempel @ 2024-07-04 5:31 UTC (permalink / raw)
To: David S. Miller, Andrew Lunn, Eric Dumazet, Florian Fainelli,
Jakub Kicinski, Paolo Abeni, Woojung Huh, Arun Ramadoss,
Heiner Kallweit, Russell King, Yuiko Oshino
Cc: Oleksij Rempel, kernel, linux-kernel, netdev, UNGLinuxDriver
Reinit PHY after cable test, otherwise link can't be established on
tested port. This issue is reproducible on LAN9372 switches with
integrated 100BaseT1 PHYs.
Fixes: 788050256c411 ("net: phy: microchip_t1: add cable test support for lan87xx phy")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
changes v2:
- add Reviewed-by: Andrew Lunn <andrew@lunn.ch>
- drop microchip specific SQI fix
drivers/net/phy/microchip_t1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/microchip_t1.c b/drivers/net/phy/microchip_t1.c
index a838b61cd844b..a35528497a576 100644
--- a/drivers/net/phy/microchip_t1.c
+++ b/drivers/net/phy/microchip_t1.c
@@ -748,7 +748,7 @@ static int lan87xx_cable_test_report(struct phy_device *phydev)
ethnl_cable_test_result(phydev, ETHTOOL_A_CABLE_PAIR_A,
lan87xx_cable_test_report_trans(detect));
- return 0;
+ return phy_init_hw(phydev);
}
static int lan87xx_cable_test_get_status(struct phy_device *phydev,
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net v2 1/1] net: phy: microchip: lan87xx: reinit PHY after cable test
2024-07-04 5:31 [PATCH net v2 1/1] net: phy: microchip: lan87xx: reinit PHY after cable test Oleksij Rempel
@ 2024-07-04 5:45 ` Oleksij Rempel
0 siblings, 0 replies; 2+ messages in thread
From: Oleksij Rempel @ 2024-07-04 5:45 UTC (permalink / raw)
To: David S. Miller, Andrew Lunn, Eric Dumazet, Florian Fainelli,
Jakub Kicinski, Paolo Abeni, Woojung Huh, Arun Ramadoss,
Heiner Kallweit, Russell King, Yuiko Oshino
Cc: kernel, linux-kernel, netdev, UNGLinuxDriver
On Thu, Jul 04, 2024 at 07:31:23AM +0200, Oleksij Rempel wrote:
> Reinit PHY after cable test, otherwise link can't be established on
> tested port. This issue is reproducible on LAN9372 switches with
> integrated 100BaseT1 PHYs.
>
> Fixes: 788050256c411 ("net: phy: microchip_t1: add cable test support for lan87xx phy")
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
I lost in this version one reviewed by:
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-04 5:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-04 5:31 [PATCH net v2 1/1] net: phy: microchip: lan87xx: reinit PHY after cable test Oleksij Rempel
2024-07-04 5:45 ` Oleksij Rempel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®