[PATCH v1] hwrng: Kconfig - Do not enable by default CN10K driver

[PATCH v1] hwrng: Kconfig - Do not enable by default CN10K driver

[Francesco Dolcini]

From: Francesco Dolcini <francesco.dolcini@toradex.com>

Do not enable by default the CN10K HW random generator driver.

CN10K Random Number Generator is available only on some specific
Marvell SoCs, however the driver is in practice enabled by default on
all arm64 configs.

Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
as an alternative I could propose

default HW_RANDOM if ARCH_THUNDER=y

---
 drivers/char/hw_random/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
index 442c40efb200..01e2e1ef82cf 100644
--- a/drivers/char/hw_random/Kconfig
+++ b/drivers/char/hw_random/Kconfig
@@ -555,7 +555,6 @@ config HW_RANDOM_ARM_SMCCC_TRNG
 config HW_RANDOM_CN10K
        tristate "Marvell CN10K Random Number Generator support"
        depends on HW_RANDOM && PCI && (ARM64 || (64BIT && COMPILE_TEST))
-       default HW_RANDOM
        help
 	 This driver provides support for the True Random Number
 	 generator available in Marvell CN10K SoCs.
-- 
2.39.2

Re: [PATCH v1] hwrng: Kconfig - Do not enable by default CN10K driver

[Herbert Xu]

On Tue, Jun 25, 2024 at 09:57:46PM +0200, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> Do not enable by default the CN10K HW random generator driver.
> 
> CN10K Random Number Generator is available only on some specific
> Marvell SoCs, however the driver is in practice enabled by default on
> all arm64 configs.
> 
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
> as an alternative I could propose
> 
> default HW_RANDOM if ARCH_THUNDER=y

Adding marvell Cc.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v1] hwrng: Kconfig - Do not enable by default CN10K driver

[Herbert Xu]

On Tue, Jun 25, 2024 at 09:57:46PM +0200, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> Do not enable by default the CN10K HW random generator driver.
> 
> CN10K Random Number Generator is available only on some specific
> Marvell SoCs, however the driver is in practice enabled by default on
> all arm64 configs.
> 
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
> as an alternative I could propose
> 
> default HW_RANDOM if ARCH_THUNDER=y
> 
> ---
>  drivers/char/hw_random/Kconfig | 1 -
>  1 file changed, 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

RE: [EXTERNAL] Re: [PATCH v1] hwrng: Kconfig - Do not enable by default CN10K driver

[Bharat Bhushan]

> From: Herbert Xu <herbert@gondor.apana.org.au> 
> Sent: Saturday, July 6, 2024 5:41 AM
> To: Francesco Dolcini <francesco@dolcini.it>; Bharat Bhushan <bbhushan2@marvell.com>
> Cc: Olivia Mackall <olivia@selenic.com>; Francesco Dolcini <francesco.dolcini@toradex.com>; linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [EXTERNAL] Re: [PATCH v1] hwrng: Kconfig - Do not enable by default CN10K driver
> 
> On Tue, Jun 25, 2024 at 09: 57: 46PM +0200, Francesco Dolcini wrote: > From: Francesco Dolcini <francesco. dolcini@ toradex. com> > > Do not enable by default the CN10K HW random generator driver. > > CN10K Random Number Generator 
> On Tue, Jun 25, 2024 at 09:57:46PM +0200, Francesco Dolcini wrote:
>> From: Francesco Dolcini <mailto:francesco.dolcini@toradex.com>
>> 
>> Do not enable by default the CN10K HW random generator driver.
>> 
>> CN10K Random Number Generator is available only on some specific
>> Marvell SoCs, however the driver is in practice enabled by default on
>> all arm64 configs.
>> 
>> Signed-off-by: Francesco Dolcini <mailto:francesco.dolcini@toradex.com>
>> ---
>> as an alternative I could propose
>> 
>> default HW_RANDOM if ARCH_THUNDER=y

Yes, make default if ARCH_THUNDER is true

Thanks
-Bharat

>Adding marvell Cc.
>Cheers,

Re: [EXTERNAL] Re: [PATCH v1] hwrng: Kconfig - Do not enable by default CN10K driver

[Francesco Dolcini]

Hello Herbert, Bharat

On Thu, Jul 18, 2024 at 10:10:31AM +0000, Bharat Bhushan wrote:
> > On Tue, Jun 25, 2024 at 09:57:46PM +0200, Francesco Dolcini wrote:
> >> From: Francesco Dolcini <mailto:francesco.dolcini@toradex.com>
> >> 
> >> Do not enable by default the CN10K HW random generator driver.
> >> 
> >> CN10K Random Number Generator is available only on some specific
> >> Marvell SoCs, however the driver is in practice enabled by default on
> >> all arm64 configs.
> >> 
> >> Signed-off-by: Francesco Dolcini <mailto:francesco.dolcini@toradex.com>
> >> ---
> >> as an alternative I could propose
> >> 
> >> default HW_RANDOM if ARCH_THUNDER=y
> 
> Yes, make default if ARCH_THUNDER is true

Herbert, this patch was merged, do you want a follow-up patch as Bharat wrote
or you are good with the current status?

Francesco

Re: [EXTERNAL] Re: [PATCH v1] hwrng: Kconfig - Do not enable by default CN10K driver

[Herbert Xu]

On Mon, Jul 22, 2024 at 08:55:40AM +0200, Francesco Dolcini wrote:
>
> > Yes, make default if ARCH_THUNDER is true
> 
> Herbert, this patch was merged, do you want a follow-up patch as Bharat wrote
> or you are good with the current status?

Please send me a follow-up patch.  Thanks!
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt