mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>,
	linux-kernel@vger.kernel.org,
	Lai Jiangshan <jiangshan.ljs@antgroup.com>
Subject: Re: [PATCH UPDATED 3/7] workqueue: Remove cpus_read_lock() from apply_wqattrs_lock()
Date: Mon, 15 Jul 2024 07:22:55 -1000	[thread overview]
Message-ID: <ZpVa7z7CFJHK_ybY@slm.duckdns.org> (raw)
In-Reply-To: <xesrnvzs4xahy4473mp5vzxemjdtrci457x76si6gqbte3xx7k@ubfomqay7tck>

Hello, Daniel.

On Mon, Jul 15, 2024 at 11:13:56AM -0400, Daniel Jordan wrote:
...
> pcrypt/padata doesn't need to hold cpus_read_lock during
> alloc_workqueue.
> 
> I didn't look closely at the workqueue changes that avoid this issue,
> but I can remove the restriction in padata if it helps to reduce
> complexity in workqueue.
> 
> I saw the recent wq pull though, so if it's fine as is, that's ok too.

I think it'd be better if workqueue can put as little restrictions as
possible to its users. alloc_workqueue() is a bit of a boundary case, I
think, but if workqueue can avoid it, I think it's better that way, so no
need to change it from pcrypt/padata.

Thanks.

-- 
tejun

  reply	other threads:[~2024-07-15 17:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-11  8:35 [PATCH 0/7] Add wq_online_cpumask and remove " Lai Jiangshan
2024-07-11  8:35 ` [PATCH 1/7] workqueue: Add wq_online_cpumask Lai Jiangshan
2024-07-11  8:35 ` [PATCH 2/7] workqueue: Simplify wq_calc_pod_cpumask() with wq_online_cpumask Lai Jiangshan
2024-07-11  8:35 ` [PATCH 3/7] workqueue: Remove cpus_read_lock() from apply_wqattrs_lock() Lai Jiangshan
2024-07-11 17:11   ` [PATCH UPDATED " Tejun Heo
2024-07-15 15:13     ` Daniel Jordan
2024-07-15 17:22       ` Tejun Heo [this message]
2024-07-16  2:01   ` [PATCH " Pengfei Xu
2024-07-11  8:35 ` [PATCH 4/7] workqueue: Remove the unneeded cpumask empty check in wq_calc_pod_cpumask() Lai Jiangshan
2024-07-11  8:35 ` [PATCH 5/7] workqueue: Remove the argument @cpu_going_down from wq_calc_pod_cpumask() Lai Jiangshan
2024-07-11  8:35 ` [PATCH 6/7] workqueue: Remove the arguments @hotplug_cpu and @online from wq_update_pod() Lai Jiangshan
2024-07-11  8:35 ` [PATCH 7/7] workqueue: Rename wq_update_pod() to unbound_wq_update_pwq() Lai Jiangshan
2024-07-11 17:12 ` [PATCH 0/7] Add wq_online_cpumask and remove cpus_read_lock() from apply_wqattrs_lock() Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZpVa7z7CFJHK_ybY@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=daniel.m.jordan@oracle.com \
    --cc=jiangshan.ljs@antgroup.com \
    --cc=jiangshanlai@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®