From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Ding, Shenghao" <shenghao-ding@ti.com>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"pierre-louis.bossart@linux.intel.com"
<pierre-louis.bossart@linux.intel.com>,
"13916275206@139.com" <13916275206@139.com>,
"zhourui@huaqin.com" <zhourui@huaqin.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Salazar, Ivan" <i-salazar@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Chadha, Jasjot Singh" <j-chadha@ti.com>,
"liam.r.girdwood@intel.com" <liam.r.girdwood@intel.com>,
"Yue, Jaden" <jaden-yue@ti.com>,
"yung-chuan.liao@linux.intel.com"
<yung-chuan.liao@linux.intel.com>, "Rao, Dipa" <dipa@ti.com>,
"yuhsuan@google.com" <yuhsuan@google.com>,
"Lo, Henry" <henry.lo@ti.com>, "tiwai@suse.de" <tiwai@suse.de>,
"Xu, Baojun" <baojun.xu@ti.com>,
"Baojun.Xu@fpt.com" <Baojun.Xu@fpt.com>,
"judyhsiao@google.com" <judyhsiao@google.com>,
"Navada Kanyana, Mukund" <navada@ti.com>,
"cujomalainey@google.com" <cujomalainey@google.com>,
"Kutty, Aanya" <aanya@ti.com>,
"Mahmud, Nayeem" <nayeem.mahmud@ti.com>,
"savyasanchi.shukla@netradyne.com"
<savyasanchi.shukla@netradyne.com>,
"flaviopr@microsoft.com" <flaviopr@microsoft.com>,
"Ji, Jesse" <jesse-ji@ti.com>,
"darren.ye@mediatek.com" <darren.ye@mediatek.com>,
"antheas.dk@gmail.com" <antheas.dk@gmail.com>,
"Jerry2.Huang@lcfuturecenter.com"
<Jerry2.Huang@lcfuturecenter.com>
Subject: Re: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Rename dai_driver name to unify the name between TAS2563 and TAS2781
Date: Fri, 16 Aug 2024 17:51:07 +0300 [thread overview]
Message-ID: <Zr9nW-rIA0TpmYVj@smile.fi.intel.com> (raw)
In-Reply-To: <2a4f9f583b5e4495b9fb50a446c2c949@ti.com>
On Fri, Aug 16, 2024 at 01:41:46PM +0000, Ding, Shenghao wrote:
> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Sent: Thursday, August 15, 2024 8:04 PM
> > To: Ding, Shenghao <shenghao-ding@ti.com>
> > On Thu, Aug 15, 2024 at 03:02:01AM +0000, Ding, Shenghao wrote:
> > > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > Sent: Monday, August 12, 2024 11:52 PM On Sat, Aug 03, 2024 at
> > > > 11:27:14AM +0800, Shenghao Ding wrote:
...
> > > > > + strscpy(name, "Speaker Profile Id",
> > > > SNDRV_CTL_ELEM_ID_NAME_MAXLEN);
> > > >
> > > > > + strscpy(prog_name, "Speaker Program Id",
> > > > > + SNDRV_CTL_ELEM_ID_NAME_MAXLEN);
> > > >
> > > > > + strscpy(conf_name, "Speaker Config Id",
> > > > > +SNDRV_CTL_ELEM_ID_NAME_MAXLEN);
> > > >
> > > > Why not 2-parameter strscpy()?
> > > strscpy seemed not support 2 params. Do you mean strcpy?
> >
> > 1. It does.
> > 2. No, I meant strscpy().
> I have tried 2-parameter strscpy(), and occurred compiling issue.
> The first parameter of strscpy, *dst, must be array, but in this code
> prog_name and conf_name are points to the memories applied by
> devm_kcalloc.
Okay, I'm not sure why devm_kasprintf() is not used for these cases.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-08-16 14:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-03 3:27 Shenghao Ding
2024-08-05 12:48 ` Mark Brown
2024-08-12 15:51 ` Andy Shevchenko
2024-08-15 3:02 ` [EXTERNAL] " Ding, Shenghao
2024-08-15 12:04 ` Andy Shevchenko
2024-08-16 13:41 ` Ding, Shenghao
2024-08-16 14:51 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zr9nW-rIA0TpmYVj@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=13916275206@139.com \
--cc=Baojun.Xu@fpt.com \
--cc=Jerry2.Huang@lcfuturecenter.com \
--cc=aanya@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=antheas.dk@gmail.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=cujomalainey@google.com \
--cc=darren.ye@mediatek.com \
--cc=dipa@ti.com \
--cc=flaviopr@microsoft.com \
--cc=henry.lo@ti.com \
--cc=i-salazar@ti.com \
--cc=j-chadha@ti.com \
--cc=jaden-yue@ti.com \
--cc=jesse-ji@ti.com \
--cc=judyhsiao@google.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=navada@ti.com \
--cc=nayeem.mahmud@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=savyasanchi.shukla@netradyne.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.de \
--cc=yuhsuan@google.com \
--cc=yung-chuan.liao@linux.intel.com \
--cc=zhourui@huaqin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®