* [PATCH] ASoc: tas2781: Rename dai_driver name to unify the name between TAS2563 and TAS2781
@ 2024-08-06 4:17 Shenghao Ding
2024-08-12 17:12 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Shenghao Ding @ 2024-08-06 4:17 UTC (permalink / raw)
To: broonie
Cc: andriy.shevchenko, lgirdwood, perex, pierre-louis.bossart,
13916275206, zhourui, alsa-devel, i-salazar, linux-kernel,
j-chadha, liam.r.girdwood, jaden-yue, yung-chuan.liao, dipa,
yuhsuan, henry.lo, tiwai, baojun.xu, soyer, Baojun.Xu, judyhsiao,
navada, cujomalainey, aanya, nayeem.mahmud, savyasanchi.shukla,
flaviopr, jesse-ji, darren.ye, antheas.dk, Jerry2.Huang,
Shenghao Ding
Rename dai_driver name to unify the name between TAS2563 and
TAS2781.
Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
---
sound/soc/codecs/tas2781-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c
index 8a57c045afdd..8f9574189e1f 100644
--- a/sound/soc/codecs/tas2781-i2c.c
+++ b/sound/soc/codecs/tas2781-i2c.c
@@ -673,7 +673,7 @@ static const struct snd_soc_dai_ops tasdevice_dai_ops = {
static struct snd_soc_dai_driver tasdevice_dai_driver[] = {
{
- .name = "tas2781_codec",
+ .name = "tasdev_codec",
.id = 0,
.playback = {
.stream_name = "Playback",
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoc: tas2781: Rename dai_driver name to unify the name between TAS2563 and TAS2781
2024-08-06 4:17 [PATCH] ASoc: tas2781: Rename dai_driver name to unify the name between TAS2563 and TAS2781 Shenghao Ding
@ 2024-08-12 17:12 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2024-08-12 17:12 UTC (permalink / raw)
To: Shenghao Ding
Cc: broonie, lgirdwood, perex, pierre-louis.bossart, 13916275206,
zhourui, alsa-devel, i-salazar, linux-kernel, j-chadha,
liam.r.girdwood, jaden-yue, yung-chuan.liao, dipa, yuhsuan,
henry.lo, tiwai, baojun.xu, soyer, Baojun.Xu, judyhsiao, navada,
cujomalainey, aanya, nayeem.mahmud, savyasanchi.shukla, flaviopr,
jesse-ji, darren.ye, antheas.dk, Jerry2.Huang
On Tue, Aug 06, 2024 at 12:17:17PM +0800, Shenghao Ding wrote:
> Rename dai_driver name to unify the name between TAS2563 and
> TAS2781.
I am not sure this is a good change. Theoretically one with the platform that
has a certain codec may connect the other one. How that will be distinguished?
If there is no issue for such configurations, please mention this fact in the
commit message.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-12 17:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-06 4:17 [PATCH] ASoc: tas2781: Rename dai_driver name to unify the name between TAS2563 and TAS2781 Shenghao Ding
2024-08-12 17:12 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®