[PATCH v2] platform/chrome: chromeos_laptop: Use kmemdup_array instead of kmemdup for multiple allocation

[PATCH v2] platform/chrome: chromeos_laptop: Use kmemdup_array instead of kmemdup for multiple allocation

[Yu Jiaoliang]

Let the kememdup_array() take care about multiplication and possible
overflows.

v2:
-Use sizeof(*i2c_peripherals) instead of sizeof(*src->i2c_peripherals)
-Format code

Signed-off-by: Yu Jiaoliang <yujiaoliang@vivo.com>
Reviewed-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/platform/chrome/chromeos_laptop.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/chrome/chromeos_laptop.c b/drivers/platform/chrome/chromeos_laptop.c
index a2cdbfbaeae6..3ab668764383 100644
--- a/drivers/platform/chrome/chromeos_laptop.c
+++ b/drivers/platform/chrome/chromeos_laptop.c
@@ -749,10 +749,9 @@ chromeos_laptop_prepare_i2c_peripherals(struct chromeos_laptop *cros_laptop,
 	if (!src->num_i2c_peripherals)
 		return 0;
 
-	i2c_peripherals = kmemdup(src->i2c_peripherals,
-					      src->num_i2c_peripherals *
-					  sizeof(*src->i2c_peripherals),
-					  GFP_KERNEL);
+	i2c_peripherals = kmemdup_array(src->i2c_peripherals,
+					src->num_i2c_peripherals,
+					sizeof(*i2c_peripherals), GFP_KERNEL);
 	if (!i2c_peripherals)
 		return -ENOMEM;
 
-- 
2.34.1

Re: [PATCH v2] platform/chrome: chromeos_laptop: Use kmemdup_array instead of kmemdup for multiple allocation

[Tzung-Bi Shih]

On Wed, Aug 21, 2024 at 07:26:29PM +0800, Yu Jiaoliang wrote:
> v2:
> -Use sizeof(*i2c_peripherals) instead of sizeof(*src->i2c_peripherals)
> -Format code

Please move the changelogs after "---" next time so that they won't be part of
commit message.

> Reviewed-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

I didn't see the tag was provided in the mailing list.

Re: [PATCH v2] platform/chrome: chromeos_laptop: Use kmemdup_array instead of kmemdup for multiple allocation

[于佼良]

在 2024/8/22 20:26, Tzung-Bi Shih 写道:
> On Wed, Aug 21, 2024 at 07:26:29PM +0800, Yu Jiaoliang wrote:
>> v2:
>> -Use sizeof(*i2c_peripherals) instead of sizeof(*src->i2c_peripherals)
>> -Format code
> Please move the changelogs after "---" next time so that they won't be part of
> commit message.
>
>> Reviewed-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> I didn't see the tag was provided in the mailing list.

Hi,

I've updated the position of the changelogs and R-b tags. Thanks~

Best Regards,

Yu