* [PATCH] fs/ntfs3: Remove the unnecessary 'if' statement
@ 2024-09-11 1:57 Qianqiang Liu
2024-09-13 2:33 ` Qianqiang Liu
0 siblings, 1 reply; 2+ messages in thread
From: Qianqiang Liu @ 2024-09-11 1:57 UTC (permalink / raw)
To: almaz.alexandrovich; +Cc: ntfs3, linux-kernel, Qianqiang Liu
The 'asize' was already checked to be less than SIZEOF_RESIDENT.
Signed-off-by: Qianqiang Liu <qianqiang.liu@163.com>
---
fs/ntfs3/record.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/fs/ntfs3/record.c b/fs/ntfs3/record.c
index 427c71be0f08..0f400366231d 100644
--- a/fs/ntfs3/record.c
+++ b/fs/ntfs3/record.c
@@ -268,10 +268,6 @@ struct ATTRIB *mi_enum_attr(struct mft_inode *mi, struct ATTRIB *attr)
/* Check size of attribute. */
if (!attr->non_res) {
- /* Check resident fields. */
- if (asize < SIZEOF_RESIDENT)
- return NULL;
-
t16 = le16_to_cpu(attr->res.data_off);
if (t16 > asize)
return NULL;
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] fs/ntfs3: Remove the unnecessary 'if' statement
2024-09-11 1:57 [PATCH] fs/ntfs3: Remove the unnecessary 'if' statement Qianqiang Liu
@ 2024-09-13 2:33 ` Qianqiang Liu
0 siblings, 0 replies; 2+ messages in thread
From: Qianqiang Liu @ 2024-09-13 2:33 UTC (permalink / raw)
To: almaz.alexandrovich; +Cc: ntfs3, linux-kernel
Hi almaz,
On Wed, Sep 11, 2024 at 09:57:54AM +0800, Qianqiang Liu wrote:
> The 'asize' was already checked to be less than SIZEOF_RESIDENT.
>
> Signed-off-by: Qianqiang Liu <qianqiang.liu@163.com>
> ---
> fs/ntfs3/record.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fs/ntfs3/record.c b/fs/ntfs3/record.c
> index 427c71be0f08..0f400366231d 100644
> --- a/fs/ntfs3/record.c
> +++ b/fs/ntfs3/record.c
> @@ -268,10 +268,6 @@ struct ATTRIB *mi_enum_attr(struct mft_inode *mi, struct ATTRIB *attr)
>
> /* Check size of attribute. */
> if (!attr->non_res) {
> - /* Check resident fields. */
> - if (asize < SIZEOF_RESIDENT)
> - return NULL;
> -
> t16 = le16_to_cpu(attr->res.data_off);
> if (t16 > asize)
> return NULL;
> --
> 2.39.2
Could you please review this patch?
--
Best,
Qianqiang Liu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-13 2:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-11 1:57 [PATCH] fs/ntfs3: Remove the unnecessary 'if' statement Qianqiang Liu
2024-09-13 2:33 ` Qianqiang Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®