[PATCH v2] staging: octeon: Use new initialization api for tasklet

[PATCH v2] staging: octeon: Use new initialization api for tasklet

[Abhishek Tamboli]

Use the new api DECLARE_TASKLET instead of DECLARE_TASKLET_OLD
introduced in commit 12cc923f1ccc ("tasklet: Introduce new
initialization API").

Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
---
Changes in v2:
- Fix the build errors
[v1]: https://lore.kernel.org/all/20240912172231.369566-1-abhishektamboli9@gmail.com/

 drivers/staging/octeon/ethernet-tx.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging/octeon/ethernet-tx.c
index bbf33b88bb7c..261f8dbdc382 100644
--- a/drivers/staging/octeon/ethernet-tx.c
+++ b/drivers/staging/octeon/ethernet-tx.c
@@ -40,8 +40,8 @@
 #define GET_SKBUFF_QOS(skb) 0
 #endif

-static void cvm_oct_tx_do_cleanup(unsigned long arg);
-static DECLARE_TASKLET_OLD(cvm_oct_tx_cleanup_tasklet, cvm_oct_tx_do_cleanup);
+static void cvm_oct_tx_do_cleanup(struct tasklet_struct *clean);
+static DECLARE_TASKLET(cvm_oct_tx_cleanup_tasklet, cvm_oct_tx_do_cleanup);

 /* Maximum number of SKBs to try to free per xmit packet. */
 #define MAX_SKB_TO_FREE (MAX_OUT_QUEUE_DEPTH * 2)
@@ -670,7 +670,7 @@ void cvm_oct_tx_shutdown_dev(struct net_device *dev)
 	}
 }

-static void cvm_oct_tx_do_cleanup(unsigned long arg)
+static void cvm_oct_tx_do_cleanup(struct tasklet_struct *clean)
 {
 	int port;

--
2.34.1

Re: [PATCH v2] staging: octeon: Use new initialization api for tasklet

[Greg KH]

On Sat, Sep 14, 2024 at 12:47:34AM +0530, Abhishek Tamboli wrote:
> Use the new api DECLARE_TASKLET instead of DECLARE_TASKLET_OLD
> introduced in commit 12cc923f1ccc ("tasklet: Introduce new
> initialization API").

This says what you are doing, but not why you are doing this.

Why is this needed?  What bug does this fix?  The code is the exact same
afterward so why should this be accepted?

thanks,

greg k-h

Re: [PATCH v2] staging: octeon: Use new initialization api for tasklet

[Abhishek Tamboli]

Hi Greg,

On Sat, Sep 14, 2024 at 10:20:02AM +0200, Greg KH wrote:
> On Sat, Sep 14, 2024 at 12:47:34AM +0530, Abhishek Tamboli wrote:
> > Use the new api DECLARE_TASKLET instead of DECLARE_TASKLET_OLD
> > introduced in commit 12cc923f1ccc ("tasklet: Introduce new
> > initialization API").
> 
> This says what you are doing, but not why you are doing this.
> 
> Why is this needed?  What bug does this fix?  The code is the exact same
> afterward so why should this be accepted?
> 
 While this patch doesn't fix any functional bug, it ensures that the 
 code is kept up to date with the new Initialization API for tasklets.

 Regards,
 Abhishek

Re: [PATCH v2] staging: octeon: Use new initialization api for tasklet

[Dan Carpenter]

On Sat, Sep 14, 2024 at 10:14:56PM +0530, Abhishek Tamboli wrote:
> Hi Greg,
> 
> On Sat, Sep 14, 2024 at 10:20:02AM +0200, Greg KH wrote:
> > On Sat, Sep 14, 2024 at 12:47:34AM +0530, Abhishek Tamboli wrote:
> > > Use the new api DECLARE_TASKLET instead of DECLARE_TASKLET_OLD
> > > introduced in commit 12cc923f1ccc ("tasklet: Introduce new
> > > initialization API").
> > 
> > This says what you are doing, but not why you are doing this.
> > 
> > Why is this needed?  What bug does this fix?  The code is the exact same
> > afterward so why should this be accepted?
> > 
>  While this patch doesn't fix any functional bug, it ensures that the 
>  code is kept up to date with the new Initialization API for tasklets.

You need to resend the patch with this information included in the commit
message.

regards,
dan carpenter