From: Bjorn Andersson <quic_bjorande@quicinc.com>
To: Mahadevan <quic_mahap@quicinc.com>
Cc: <robdclark@gmail.com>, <quic_abhinavk@quicinc.com>,
<dmitry.baryshkov@linaro.org>, <sean@poorly.run>,
<marijn.suijten@somainline.org>, <airlied@gmail.com>,
<daniel@ffwll.ch>, <maarten.lankhorst@linux.intel.com>,
<mripard@kernel.org>, <tzimmermann@suse.de>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<swboyd@chromium.org>, <konrad.dybcio@linaro.org>,
<danila@jiaxyga.com>, <bigfoot@classfun.cn>,
<neil.armstrong@linaro.org>, <mailingradian@gmail.com>,
<quic_jesszhan@quicinc.com>, <andersson@kernel.org>,
<linux-arm-msm@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<freedreno@lists.freedesktop.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_kalyant@quicinc.com>,
<quic_jmadiset@quicinc.com>, <quic_vpolimer@quicinc.com>
Subject: Re: [PATCH v2 1/5] dt-bindings: display/msm: Document MDSS on SA8775P
Date: Thu, 26 Sep 2024 06:24:40 -0700 [thread overview]
Message-ID: <ZvVgmFUs2bwfEoWD@hu-bjorande-lv.qualcomm.com> (raw)
In-Reply-To: <20240926110137.2200158-2-quic_mahap@quicinc.com>
On Thu, Sep 26, 2024 at 04:31:33PM +0530, Mahadevan wrote:
> Document the MDSS hardware found on the Qualcomm SA8775P platform.
>
> Signed-off-by: Mahadevan <quic_mahap@quicinc.com>
> ---
>
> [v2]
> - Use fake DISPCC nodes to avoid clock dependencies in dt-bindings. [Dmitry]
> - Update bindings by fixing dt_binding_check tool errors (update includes in example),
> adding proper spacing and indentation in binding example, dropping unused labels,
> dropping status disable, adding reset node. [Dmitry, Rob, Krzysztof]
No concerns with the changelog, but please adopt b4 (go/upstream has
instructions) for sending patches upstream.
>
> ---
> .../display/msm/qcom,sa8775p-mdss.yaml | 239 ++++++++++++++++++
> 1 file changed, 239 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> new file mode 100644
> index 000000000000..e610b66ffa9f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> @@ -0,0 +1,239 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/msm/qcom,sa8775p-mdss.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies, Inc. SA87755P Display MDSS
> +
> +maintainers:
> + - Mahadevan <quic_mahap@quicinc.com>
Please use Firstname Lastname, if possible
> +
> +description:
> + SA8775P MSM Mobile Display Subsystem(MDSS), which encapsulates sub-blocks like
> + DPU display controller, DP interfaces and EDP etc.
> +
> +$ref: /schemas/display/msm/mdss-common.yaml#
> +
[..]
> +
> +examples:
> + - |
> + #include <dt-bindings/interconnect/qcom,icc.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/qcom,sa8775p-gcc.h>
> + #include <dt-bindings/interconnect/qcom,sa8775p-rpmh.h>
> + #include <dt-bindings/power/qcom,rpmhpd.h>
> + #include <dt-bindings/power/qcom-rpmpd.h>
> +
> + display-subsystem@ae00000 {
> + compatible = "qcom,sa8775p-mdss";
> + reg = <0 0x0ae00000 0 0x1000>;
#address-cells and #size-cells are 1 in the example root node, so drop
the two 0 entries.
> + reg-names = "mdss";
> +
> + /* same path used twice */
What do you mean? All three paths below are unique.
> + interconnects = <&mmss_noc MASTER_MDP0 0 &mc_virt SLAVE_EBI1 0>,
> + <&mmss_noc MASTER_MDP1 0 &mc_virt SLAVE_EBI1 0>,
> + <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
> + &config_noc SLAVE_DISPLAY_CFG QCOM_ICC_TAG_ACTIVE_ONLY>;
> + interconnect-names = "mdp0-mem",
> + "mdp1-mem",
> + "cpu-cfg";
> +
> +
Regards,
Bjorn
next prev parent reply other threads:[~2024-09-26 13:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 11:01 [PATCH v2 0/5] Display enablement changes for Qualcomm SA8775P platform Mahadevan
2024-09-26 11:01 ` [PATCH v2 1/5] dt-bindings: display/msm: Document MDSS on SA8775P Mahadevan
2024-09-26 12:59 ` Dmitry Baryshkov
2024-09-26 13:01 ` Rob Herring (Arm)
2024-09-26 13:24 ` Bjorn Andersson [this message]
2024-09-30 9:01 ` Mahadevan P
2024-09-26 13:46 ` Krzysztof Kozlowski
2024-09-26 11:01 ` [PATCH v2 2/5] dt-bindings: display/msm: Document the DPU for SA8775P Mahadevan
2024-09-26 13:00 ` Dmitry Baryshkov
2024-09-26 13:01 ` Rob Herring (Arm)
2024-09-26 13:47 ` Krzysztof Kozlowski
2024-09-26 11:01 ` [PATCH v2 3/5] drm/msm: mdss: Add SA8775P support Mahadevan
2024-09-26 13:02 ` Dmitry Baryshkov
2024-09-27 6:44 ` Mahadevan P
2024-09-27 8:42 ` Dmitry Baryshkov
2024-09-26 11:01 ` [PATCH v2 4/5] drm/msm/dpu: " Mahadevan
2024-09-26 13:09 ` Dmitry Baryshkov
2024-09-30 15:41 ` Mahadevan P
2024-09-26 11:01 ` [PATCH v2 5/5] arm64: dts: qcom: sa8775p: add display dt nodes Mahadevan
2024-09-26 13:12 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvVgmFUs2bwfEoWD@hu-bjorande-lv.qualcomm.com \
--to=quic_bjorande@quicinc.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=bigfoot@classfun.cn \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=danila@jiaxyga.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mailingradian@gmail.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=quic_jmadiset@quicinc.com \
--cc=quic_kalyant@quicinc.com \
--cc=quic_mahap@quicinc.com \
--cc=quic_vpolimer@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®