* [PATCH v2] sched_ext: use correct function name in pick_task_scx() warning message
@ 2024-10-10 3:34 Honglei Wang
2024-10-10 16:36 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Honglei Wang @ 2024-10-10 3:34 UTC (permalink / raw)
To: tj, void
Cc: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, bsegall, mgorman, vschneid, linux-kernel
pick_next_task_scx() was turned into pick_task_scx() since
commit 753e2836d139 ("sched_ext: Unify regular and core-sched pick
task paths"). Update the outdated message.
Signed-off-by: Honglei Wang <jameshongleiwang@126.com>
---
Changes since v1:
- use __func__ to address the function name base on David's suggestion
kernel/sched/ext.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
index 410a4df8a121..c2596e7581fb 100644
--- a/kernel/sched/ext.c
+++ b/kernel/sched/ext.c
@@ -2958,8 +2958,8 @@ static struct task_struct *pick_task_scx(struct rq *rq)
if (unlikely(!p->scx.slice)) {
if (!scx_rq_bypassing(rq) && !scx_warned_zero_slice) {
- printk_deferred(KERN_WARNING "sched_ext: %s[%d] has zero slice in pick_next_task_scx()\n",
- p->comm, p->pid);
+ printk_deferred(KERN_WARNING "sched_ext: %s[%d] has zero slice in %s()\n",
+ p->comm, p->pid, __func__);
scx_warned_zero_slice = true;
}
p->scx.slice = SCX_SLICE_DFL;
--
2.24.3 (Apple Git-128)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] sched_ext: use correct function name in pick_task_scx() warning message
2024-10-10 3:34 [PATCH v2] sched_ext: use correct function name in pick_task_scx() warning message Honglei Wang
@ 2024-10-10 16:36 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2024-10-10 16:36 UTC (permalink / raw)
To: Honglei Wang
Cc: void, mingo, peterz, juri.lelli, vincent.guittot,
dietmar.eggemann, rostedt, bsegall, mgorman, vschneid,
linux-kernel
On Thu, Oct 10, 2024 at 11:34:05AM +0800, Honglei Wang wrote:
> pick_next_task_scx() was turned into pick_task_scx() since
> commit 753e2836d139 ("sched_ext: Unify regular and core-sched pick
> task paths"). Update the outdated message.
>
> Signed-off-by: Honglei Wang <jameshongleiwang@126.com>
Patch updated in tree.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-10 16:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-10 3:34 [PATCH v2] sched_ext: use correct function name in pick_task_scx() warning message Honglei Wang
2024-10-10 16:36 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®