mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/1] perf tests: Remove dangling CFLAGS for removed attr.o object
@ 2024-11-04 14:34 Arnaldo Carvalho de Melo
  2024-11-04 20:37 ` Ian Rogers
  2024-11-05 16:41 ` Namhyung Kim
  0 siblings, 2 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2024-11-04 14:34 UTC (permalink / raw)
  To: Namhyung Kim
  Cc: Ian Rogers, Athira Rajeev, Howard Chu, James Clark, Leo Yan,
	Stephen Rothwell, Thomas Richter, Veronika Molnarova,
	Weilin Wang, Ze Gao, zhaimingbing, Linux Kernel Mailing List,
	linux-perf-users

Since the C test wrapper for attr.py was removed we don't have an attr.o
object for that CFLAGS_attr.o to apply for, remove it.

Fixes: 3a447031f5fc21c4 ("perf test: Remove C test wrapper for attr.py")
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: Howard Chu <howardchu95@gmail.com>
Cc: Ian Rogers <irogers@google.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Leo Yan <leo.yan@linux.dev>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Thomas Richter <tmricht@linux.ibm.com>
Cc: Veronika Molnarova <vmolnaro@redhat.com>
Cc: Weilin Wang <weilin.wang@intel.com>
Cc: Ze Gao <zegao2021@gmail.com>
Cc: zhaimingbing <zhaimingbing@cmss.chinamobile.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/tests/Build | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/perf/tests/Build b/tools/perf/tests/Build
index 03cbdf7c50a09be4..01ed9335db4dba4e 100644
--- a/tools/perf/tests/Build
+++ b/tools/perf/tests/Build
@@ -72,7 +72,6 @@ ifeq ($(SRCARCH),$(filter $(SRCARCH),x86 arm arm64 powerpc))
 perf-test-$(CONFIG_DWARF_UNWIND) += dwarf-unwind.o
 endif
 
-CFLAGS_attr.o         += -DBINDIR="BUILD_STR($(bindir_SQ))" -DPYTHON="BUILD_STR($(PYTHON_WORD))"
 CFLAGS_python-use.o   += -DPYTHONPATH="BUILD_STR($(OUTPUT)python)" -DPYTHON="BUILD_STR($(PYTHON_WORD))"
 CFLAGS_dwarf-unwind.o += -fno-optimize-sibling-calls
 
-- 
2.47.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] perf tests: Remove dangling CFLAGS for removed attr.o object
  2024-11-04 14:34 [PATCH 1/1] perf tests: Remove dangling CFLAGS for removed attr.o object Arnaldo Carvalho de Melo
@ 2024-11-04 20:37 ` Ian Rogers
  2024-11-05 16:41 ` Namhyung Kim
  1 sibling, 0 replies; 3+ messages in thread
From: Ian Rogers @ 2024-11-04 20:37 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo
  Cc: Namhyung Kim, Athira Rajeev, Howard Chu, James Clark, Leo Yan,
	Stephen Rothwell, Thomas Richter, Veronika Molnarova,
	Weilin Wang, Ze Gao, zhaimingbing, Linux Kernel Mailing List,
	linux-perf-users

On Mon, Nov 4, 2024 at 6:35 AM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
> Since the C test wrapper for attr.py was removed we don't have an attr.o
> object for that CFLAGS_attr.o to apply for, remove it.
>
> Fixes: 3a447031f5fc21c4 ("perf test: Remove C test wrapper for attr.py")
> Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
> Cc: Howard Chu <howardchu95@gmail.com>
> Cc: Ian Rogers <irogers@google.com>
> Cc: James Clark <james.clark@linaro.org>
> Cc: Leo Yan <leo.yan@linux.dev>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Thomas Richter <tmricht@linux.ibm.com>
> Cc: Veronika Molnarova <vmolnaro@redhat.com>
> Cc: Weilin Wang <weilin.wang@intel.com>
> Cc: Ze Gao <zegao2021@gmail.com>
> Cc: zhaimingbing <zhaimingbing@cmss.chinamobile.com>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/tests/Build | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/tests/Build b/tools/perf/tests/Build
> index 03cbdf7c50a09be4..01ed9335db4dba4e 100644
> --- a/tools/perf/tests/Build
> +++ b/tools/perf/tests/Build
> @@ -72,7 +72,6 @@ ifeq ($(SRCARCH),$(filter $(SRCARCH),x86 arm arm64 powerpc))
>  perf-test-$(CONFIG_DWARF_UNWIND) += dwarf-unwind.o
>  endif
>
> -CFLAGS_attr.o         += -DBINDIR="BUILD_STR($(bindir_SQ))" -DPYTHON="BUILD_STR($(PYTHON_WORD))"
>  CFLAGS_python-use.o   += -DPYTHONPATH="BUILD_STR($(OUTPUT)python)" -DPYTHON="BUILD_STR($(PYTHON_WORD))"
>  CFLAGS_dwarf-unwind.o += -fno-optimize-sibling-calls
>
> --
> 2.47.0
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] perf tests: Remove dangling CFLAGS for removed attr.o object
  2024-11-04 14:34 [PATCH 1/1] perf tests: Remove dangling CFLAGS for removed attr.o object Arnaldo Carvalho de Melo
  2024-11-04 20:37 ` Ian Rogers
@ 2024-11-05 16:41 ` Namhyung Kim
  1 sibling, 0 replies; 3+ messages in thread
From: Namhyung Kim @ 2024-11-05 16:41 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo
  Cc: Ian Rogers, Athira Rajeev, Howard Chu, James Clark, Leo Yan,
	Stephen Rothwell, Thomas Richter, Veronika Molnarova,
	Weilin Wang, Ze Gao, zhaimingbing, Linux Kernel Mailing List,
	linux-perf-users

On Mon, 04 Nov 2024 11:34:58 -0300, Arnaldo Carvalho de Melo wrote:

> Since the C test wrapper for attr.py was removed we don't have an attr.o
> object for that CFLAGS_attr.o to apply for, remove it.
> 
> 

Applied to perf-tools-next, thanks!

Best regards,
Namhyung


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-11-05 16:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-04 14:34 [PATCH 1/1] perf tests: Remove dangling CFLAGS for removed attr.o object Arnaldo Carvalho de Melo
2024-11-04 20:37 ` Ian Rogers
2024-11-05 16:41 ` Namhyung Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®