From: Corey Minyard <corey@minyard.net>
To: liujing <liujing@cmss.chinamobile.com>
Cc: minyard@acm.org, openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char:ipmi: Fix the wrong format specifier
Date: Wed, 6 Nov 2024 07:00:08 -0600 [thread overview]
Message-ID: <ZytoWGTQ4fn9KpV2@mail.minyard.net> (raw)
In-Reply-To: <20241106111458.2157-1-liujing@cmss.chinamobile.com>
On Wed, Nov 06, 2024 at 07:14:58PM +0800, liujing wrote:
> Because the types of io.regsize and io.regspacing in the ipmipci_probe function are unsigned int,
> they should be output in the %u format.
I reformatted the above text to fit into 80 characters, but this is
right, I've applied it.
-corey
>
> Signed-off-by: liujing <liujing@cmss.chinamobile.com>
>
> diff --git a/drivers/char/ipmi/ipmi_si_pci.c b/drivers/char/ipmi/ipmi_si_pci.c
> index b83d55685b22..8c0ea637aba0 100644
> --- a/drivers/char/ipmi/ipmi_si_pci.c
> +++ b/drivers/char/ipmi/ipmi_si_pci.c
> @@ -118,7 +118,7 @@ static int ipmi_pci_probe(struct pci_dev *pdev,
> if (io.irq)
> io.irq_setup = ipmi_std_irq_setup;
>
> - dev_info(&pdev->dev, "%pR regsize %d spacing %d irq %d\n",
> + dev_info(&pdev->dev, "%pR regsize %u spacing %u irq %d\n",
> &pdev->resource[0], io.regsize, io.regspacing, io.irq);
>
> return ipmi_si_add_smi(&io);
> --
> 2.27.0
>
>
>
prev parent reply other threads:[~2024-11-06 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 11:14 liujing
2024-11-06 13:00 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZytoWGTQ4fn9KpV2@mail.minyard.net \
--to=corey@minyard.net \
--cc=linux-kernel@vger.kernel.org \
--cc=liujing@cmss.chinamobile.com \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®