* [PATCH] char:ipmi: Fix the wrong format specifier
@ 2024-11-06 11:14 liujing
2024-11-06 13:00 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: liujing @ 2024-11-06 11:14 UTC (permalink / raw)
To: minyard; +Cc: openipmi-developer, linux-kernel, liujing
Because the types of io.regsize and io.regspacing in the ipmipci_probe function are unsigned int,
they should be output in the %u format.
Signed-off-by: liujing <liujing@cmss.chinamobile.com>
diff --git a/drivers/char/ipmi/ipmi_si_pci.c b/drivers/char/ipmi/ipmi_si_pci.c
index b83d55685b22..8c0ea637aba0 100644
--- a/drivers/char/ipmi/ipmi_si_pci.c
+++ b/drivers/char/ipmi/ipmi_si_pci.c
@@ -118,7 +118,7 @@ static int ipmi_pci_probe(struct pci_dev *pdev,
if (io.irq)
io.irq_setup = ipmi_std_irq_setup;
- dev_info(&pdev->dev, "%pR regsize %d spacing %d irq %d\n",
+ dev_info(&pdev->dev, "%pR regsize %u spacing %u irq %d\n",
&pdev->resource[0], io.regsize, io.regspacing, io.irq);
return ipmi_si_add_smi(&io);
--
2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] char:ipmi: Fix the wrong format specifier
2024-11-06 11:14 [PATCH] char:ipmi: Fix the wrong format specifier liujing
@ 2024-11-06 13:00 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2024-11-06 13:00 UTC (permalink / raw)
To: liujing; +Cc: minyard, openipmi-developer, linux-kernel
On Wed, Nov 06, 2024 at 07:14:58PM +0800, liujing wrote:
> Because the types of io.regsize and io.regspacing in the ipmipci_probe function are unsigned int,
> they should be output in the %u format.
I reformatted the above text to fit into 80 characters, but this is
right, I've applied it.
-corey
>
> Signed-off-by: liujing <liujing@cmss.chinamobile.com>
>
> diff --git a/drivers/char/ipmi/ipmi_si_pci.c b/drivers/char/ipmi/ipmi_si_pci.c
> index b83d55685b22..8c0ea637aba0 100644
> --- a/drivers/char/ipmi/ipmi_si_pci.c
> +++ b/drivers/char/ipmi/ipmi_si_pci.c
> @@ -118,7 +118,7 @@ static int ipmi_pci_probe(struct pci_dev *pdev,
> if (io.irq)
> io.irq_setup = ipmi_std_irq_setup;
>
> - dev_info(&pdev->dev, "%pR regsize %d spacing %d irq %d\n",
> + dev_info(&pdev->dev, "%pR regsize %u spacing %u irq %d\n",
> &pdev->resource[0], io.regsize, io.regspacing, io.irq);
>
> return ipmi_si_add_smi(&io);
> --
> 2.27.0
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-06 13:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-06 11:14 [PATCH] char:ipmi: Fix the wrong format specifier liujing
2024-11-06 13:00 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®