* [PATCH v2] crypto: qat - Fix missing destroy_workqueue in adf_init_aer()
@ 2024-10-29 15:05 Wang Hai
2024-11-10 3:54 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Wang Hai @ 2024-10-29 15:05 UTC (permalink / raw)
To: giovanni.cabiddu, herbert, davem, ahsan.atta, mun.chun.yep,
markas.rapoportas, damian.muszynski, furong.zhou, adam.guerin,
zhangxiaoxu5
Cc: qat-linux, linux-crypto, linux-kernel, wanghai38
The adf_init_aer() won't destroy device_reset_wq when alloc_workqueue()
for device_sriov_wq failed. Add destroy_workqueue for device_reset_wq to
fix this issue.
Fixes: 4469f9b23468 ("crypto: qat - re-enable sriov after pf reset")
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
v1->v2: add 'device_reset_wq = NULL'
drivers/crypto/intel/qat/qat_common/adf_aer.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/intel/qat/qat_common/adf_aer.c b/drivers/crypto/intel/qat/qat_common/adf_aer.c
index ec7913ab00a2..4cb8bd83f570 100644
--- a/drivers/crypto/intel/qat/qat_common/adf_aer.c
+++ b/drivers/crypto/intel/qat/qat_common/adf_aer.c
@@ -281,8 +281,11 @@ int adf_init_aer(void)
return -EFAULT;
device_sriov_wq = alloc_workqueue("qat_device_sriov_wq", 0, 0);
- if (!device_sriov_wq)
+ if (!device_sriov_wq) {
+ destroy_workqueue(device_reset_wq);
+ device_reset_wq = NULL;
return -EFAULT;
+ }
return 0;
}
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] crypto: qat - Fix missing destroy_workqueue in adf_init_aer()
2024-10-29 15:05 [PATCH v2] crypto: qat - Fix missing destroy_workqueue in adf_init_aer() Wang Hai
@ 2024-11-10 3:54 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2024-11-10 3:54 UTC (permalink / raw)
To: Wang Hai
Cc: giovanni.cabiddu, davem, ahsan.atta, mun.chun.yep,
markas.rapoportas, damian.muszynski, furong.zhou, adam.guerin,
zhangxiaoxu5, qat-linux, linux-crypto, linux-kernel
On Tue, Oct 29, 2024 at 11:05:23PM +0800, Wang Hai wrote:
> The adf_init_aer() won't destroy device_reset_wq when alloc_workqueue()
> for device_sriov_wq failed. Add destroy_workqueue for device_reset_wq to
> fix this issue.
>
> Fixes: 4469f9b23468 ("crypto: qat - re-enable sriov after pf reset")
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> ---
> v1->v2: add 'device_reset_wq = NULL'
> drivers/crypto/intel/qat/qat_common/adf_aer.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-10 3:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-29 15:05 [PATCH v2] crypto: qat - Fix missing destroy_workqueue in adf_init_aer() Wang Hai
2024-11-10 3:54 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®