* [PATCH v3] sched_ext: Replace scx_next_task_picked() with switch_class() in comment
@ 2024-11-15 1:17 Zhao Mengmeng
2024-11-15 1:31 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Zhao Mengmeng @ 2024-11-15 1:17 UTC (permalink / raw)
To: tj, void; +Cc: zhaomengmeng, linux-kernel
From: Zhao Mengmeng <zhaomengmeng@kylinos.cn>
scx_next_task_picked() has been replaced with siwtch_class(), but comment
is still referencing old one, so replace it.
Signed-off-by: Zhao Mengmeng <zhaomengmeng@kylinos.cn>
---
kernel/sched/ext.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
index 0036696e7063..9f9bc2930658 100644
--- a/kernel/sched/ext.c
+++ b/kernel/sched/ext.c
@@ -2759,7 +2759,7 @@ static int balance_one(struct rq *rq, struct task_struct *prev)
* If the previous sched_class for the current CPU was not SCX,
* notify the BPF scheduler that it again has control of the
* core. This callback complements ->cpu_release(), which is
- * emitted in scx_next_task_picked().
+ * emitted in switch_class().
*/
if (SCX_HAS_OP(cpu_acquire))
SCX_CALL_OP(SCX_KF_REST, cpu_acquire, cpu_of(rq), NULL);
@@ -6091,7 +6091,7 @@ static void kick_cpus_irq_workfn(struct irq_work *irq_work)
if (cpu != cpu_of(this_rq)) {
/*
* Pairs with smp_store_release() issued by this CPU in
- * scx_next_task_picked() on the resched path.
+ * switch_class() on the resched path.
*
* We busy-wait here to guarantee that no other task can
* be scheduled on our core before the target CPU has
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v3] sched_ext: Replace scx_next_task_picked() with switch_class() in comment
2024-11-15 1:17 [PATCH v3] sched_ext: Replace scx_next_task_picked() with switch_class() in comment Zhao Mengmeng
@ 2024-11-15 1:31 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2024-11-15 1:31 UTC (permalink / raw)
To: Zhao Mengmeng; +Cc: void, zhaomengmeng, linux-kernel
On Fri, Nov 15, 2024 at 09:17:09AM +0800, Zhao Mengmeng wrote:
> From: Zhao Mengmeng <zhaomengmeng@kylinos.cn>
>
> scx_next_task_picked() has been replaced with siwtch_class(), but comment
> is still referencing old one, so replace it.
>
> Signed-off-by: Zhao Mengmeng <zhaomengmeng@kylinos.cn>
Applied to sched_ext/for-6.13.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-15 1:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-15 1:17 [PATCH v3] sched_ext: Replace scx_next_task_picked() with switch_class() in comment Zhao Mengmeng
2024-11-15 1:31 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®